Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4762)

Unified Diff: chrome/browser/services/gcm/push_messaging_browsertest.cc

Issue 884093003: Propagate push command line flag to the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/services/gcm/push_messaging_browsertest.cc
diff --git a/chrome/browser/services/gcm/push_messaging_browsertest.cc b/chrome/browser/services/gcm/push_messaging_browsertest.cc
index 36c5b913698a240dd2edde9d0776b6e76a3e2ed5..5b20c301b8c1b234531234be67fc174e7418ad3b 100644
--- a/chrome/browser/services/gcm/push_messaging_browsertest.cc
+++ b/chrome/browser/services/gcm/push_messaging_browsertest.cc
@@ -362,8 +362,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, RegisterPersisted) {
EXPECT_EQ(app_id_sw1.ToString(), gcm_service()->last_registered_app_id());
}
-// Disabled due to failures: crbug.com/452666
-IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, DISABLED_PushEventSuccess) {
+IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PushEventSuccess) {
std::string script_result;
TryToRegisterSuccessfully("1-0" /* expected_push_registration_id */);
@@ -466,9 +465,8 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PushEventNoPermission) {
}
#if defined(ENABLE_NOTIFICATIONS)
-// Disabled due to failures: crbug.com/452666
IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
- DISABLED_PushEventEnforcesUserVisibleNotification) {
+ PushEventEnforcesUserVisibleNotification) {
std::string script_result;
TryToRegisterSuccessfully("1-0" /* expected_push_registration_id */);
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698