Cpp bindings: add typedef for callbacks.

Cpp bindings: add typedef for callbacks.

BUG=None
TEST=None
R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/0fed816a9a81bd93fc40b368b390b9ab8452d2e8

[yzshen1, 2015-01-28 17:13:21]

yzshen@chromium.org changed reviewers:
+ jamesr@chromium.org

[yzshen1, 2015-01-28 17:13:22]

Hi, James.

Would you please take a look? Thanks!

[jamesr, 2015-01-28 17:25:32]

nice! lgtm

https://codereview.chromium.org/884043003/diff/1/mojo/public/tools/bindings/g...
File
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl
(right):

https://codereview.chromium.org/884043003/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl:48:
typedef {{interface_macros.declare_callback(method)}} {{method.name}}Callback;
can you use the 'using' syntax instead? i.e.

using {{method.name}}Callback = {{interface_macros...}};

that's what our style guide recommends and marginally easier to parse for humans
(imo) since the name of the type alias is at the beginning instead of buried at
the end

[yzshen1, 2015-01-28 18:30:43]

Thanks, James.

https://codereview.chromium.org/884043003/diff/1/mojo/public/tools/bindings/g...
File
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl
(right):

https://codereview.chromium.org/884043003/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl:48:
typedef {{interface_macros.declare_callback(method)}} {{method.name}}Callback;
On 2015/01/28 17:25:32, jamesr wrote:
> can you use the 'using' syntax instead? i.e.
> 
> using {{method.name}}Callback = {{interface_macros...}};
> 
> that's what our style guide recommends and marginally easier to parse for
humans
> (imo) since the name of the type alias is at the beginning instead of buried
at
> the end

Done.

[yzshen1, 2015-01-28 18:35:09]

Committed patchset #2 (id:20001) manually as
0fed816a9a81bd93fc40b368b390b9ab8452d2e8 (presubmit successful).