mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl - Issue 884043003: Cpp bindings: add typedef for callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

Issue 884043003: Cpp bindings: add typedef for callbacks. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: use using instead of typedef in cpp templates Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

index fbefce2d397192a0003377c120bca8d379184fc4..7644b2ef0440200b4b5d8844de69e55dbe9a9a8c 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

@@ -17,7 +17,7 @@ mojo::Callback<void(

{%- macro declare_request_params(prefix, method) -%}

{%- if method.response_parameters != None -%}

-{%- if method.parameters %}, {% endif %}

-const {{declare_callback(method)}}& callback

+{%- if method.parameters %}, {% endif -%}

+const {{method.name}}Callback& callback

{%- endif -%}

{%- endmacro -%}