Issue 883953003: Mojo JS Bindings: Add support for closing Proxy and Stub connections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 883953003: Mojo JS Bindings: Add support for closing Proxy and Stub connections (Closed)

Created:
5 years, 10 months ago by hansmuller

Modified:
5 years, 10 months ago

Reviewers:
jamesr, hansmuller1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Mojo JS Bindings: Add support for closing Proxy and Stub connections BUG= R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b771939fc2d50a6913267de76f777d242f50d383

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -5 lines)			Patch
M	mojo/public/js/bindings.js	View	2 chunks	+21 lines, -1 line	0 comments	Download
M	mojo/public/js/connection.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/services/public/js/shell.js	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hansmuller1

PTAL. This is a TODO item from the last round of Mojom de-clienting.

5 years, 10 months ago (2015-01-28 17:25:26 UTC) #3

hansmuller

5 years, 10 months ago (2015-01-28 17:27:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b771939fc2d50a6913267de76f777d242f50d383 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages