Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: mojo/services/public/js/shell.js

Issue 883953003: Mojo JS Bindings: Add support for closing Proxy and Stub connections (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/js/connection.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/public/js/shell.js
diff --git a/mojo/services/public/js/shell.js b/mojo/services/public/js/shell.js
index d80a2e9ad57e734ec5fe41dfc03d339f3fbd7e0e..e6c2dee1fdb0a2d1e032c6220cd41f2a93d9c1dc 100644
--- a/mojo/services/public/js/shell.js
+++ b/mojo/services/public/js/shell.js
@@ -46,8 +46,7 @@ define("mojo/services/public/js/shell", [
this.applications_.forEach(function(application, url) {
application.close();
});
- // TODO(hansmuller): Use a proper API on Proxy to close.
- core.close(this.shellProxy.handleStash);
+ ProxyBindings(this.shellProxy).close();
this.applications_.clear();
}
}
« no previous file with comments | « mojo/public/js/connection.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698