Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 883803002: Expose API on VariationsService to set the restrict mode param. (Closed)

Created:
5 years, 11 months ago by Alexei Svitkine (slow)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose API on VariationsService to set the restrict mode param. This paves the way to allowing logic living elsewhere in Chrome to specify a value for this param (which will come in a later CL). Also, cleans up a couple areas of the code, including cleaning up the unit test for the URL generating function to abstract away the policy pref code and using a weak pointer instead of base::Unretained() in a callback. BUG=452605 Committed: https://crrev.com/96339279b60df2f9811b0d56d4d435f1069c4e50 Cr-Commit-Position: refs/heads/master@{#313504}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -73 lines) Patch
M chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.h View 2 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 4 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 4 chunks +67 lines, -59 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Alexei Svitkine (slow)
5 years, 11 months ago (2015-01-27 19:51:41 UTC) #7
jwd
lgtm
5 years, 11 months ago (2015-01-27 22:47:19 UTC) #8
Alexei Svitkine (slow)
+mnissler for policy/ owners
5 years, 11 months ago (2015-01-27 22:52:23 UTC) #10
Mattias Nissler (ping if slow)
policy/ LGTM Feel free to TBR trivial adjustments after API changes have reviewed by respective ...
5 years, 10 months ago (2015-01-28 09:07:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883803002/100001
5 years, 10 months ago (2015-01-28 14:24:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:100001)
5 years, 10 months ago (2015-01-28 14:32:49 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 14:33:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96339279b60df2f9811b0d56d4d435f1069c4e50
Cr-Commit-Position: refs/heads/master@{#313504}

Powered by Google App Engine
This is Rietveld 408576698