Expose API on VariationsService to set the restrict mode param.

chrome/browser/metrics/variations/variations_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/variations/variations_service.h"
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/prefs/testing_pref_service.h"
@@ skipping 133 matching lines @@
 // Simulates a variations service response by setting a date header and the
 // specified HTTP |response_code| on |fetcher|.
 void SimulateServerResponse(int response_code, net::TestURLFetcher* fetcher) {
   ASSERT_TRUE(fetcher);
   scoped_refptr<net::HttpResponseHeaders> headers(
       new net::HttpResponseHeaders("date:Wed, 13 Feb 2013 00:25:24 GMT\0\0"));
   fetcher->set_response_headers(headers);
   fetcher->set_response_code(response_code);
 }
 
+// Helper class that abstracts away platform-specific details relating to the
+// pref store used for the "restrict" param policy.
+class TestVariationsPrefsStore {
+ public:
+  TestVariationsPrefsStore() {
+#if defined(OS_ANDROID)
+    // Android uses profile prefs as the PrefService to generate the URL.
+    VariationsService::RegisterProfilePrefs(prefs_.registry());
+#else
+    VariationsService::RegisterPrefs(prefs_.registry());
+#endif
+
+#if defined(OS_CHROMEOS)
+    cros_settings_ = chromeos::CrosSettings::Get();
+    DCHECK(cros_settings_ != NULL);
+    // Remove the real DeviceSettingsProvider and replace it with a stub that
+    // allows modifications in a test.
+    // TODO(asvitkine): Make a scoped helper class for this operation.
+    device_settings_provider_ = cros_settings_->GetProvider(
+        chromeos::kReportDeviceVersionInfo);
+    EXPECT_TRUE(device_settings_provider_ != NULL);
+    EXPECT_TRUE(cros_settings_->RemoveSettingsProvider(
+        device_settings_provider_));
+    cros_settings_->AddSettingsProvider(&stub_settings_provider_);
+#endif
+  }
+
+  ~TestVariationsPrefsStore() {
+#if defined(OS_CHROMEOS)
+    // Restore the real DeviceSettingsProvider.
+    EXPECT_TRUE(
+        cros_settings_->RemoveSettingsProvider(&stub_settings_provider_));
+    cros_settings_->AddSettingsProvider(device_settings_provider_);
+#endif
+  }
+
+  void SetVariationsRestrictParameterPolicyValue(const std::string& value) {
+#if defined(OS_CHROMEOS)
+    cros_settings_->SetString(chromeos::kVariationsRestrictParameter, value);
+#else
+    prefs_.SetString(prefs::kVariationsRestrictParameter, value);
+#endif
+  }
+
+  PrefService* prefs() { return &prefs_; }
+
+ private:
+#if defined(OS_ANDROID)
+  // Android uses profile prefs as the PrefService to generate the URL.
+  TestingPrefServiceSyncable prefs_;
+#else
+  TestingPrefServiceSimple prefs_;
+#endif
+
+#if defined(OS_CHROMEOS)
+  chromeos::CrosSettings* cros_settings_;
+  chromeos::StubCrosSettingsProvider stub_settings_provider_;
+  chromeos::CrosSettingsProvider* device_settings_provider_;
+#endif
+
+  DISALLOW_COPY_AND_ASSIGN(TestVariationsPrefsStore);
+};
+
 }  // namespace
 
 class VariationsServiceTest : public ::testing::Test {
  protected:
   VariationsServiceTest() {}
 
  private:
 #if defined(OS_CHROMEOS)
   // Not used directly. Initializes CrosSettings for testing.
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
   chromeos::ScopedTestCrosSettings test_cros_settings_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(VariationsServiceTest);
 };
 
-#if !defined(OS_CHROMEOS)
-TEST_F(VariationsServiceTest, VariationsURLIsValid) {
-#if defined(OS_ANDROID)
-  // Android uses profile prefs as the PrefService to generate the URL.
-  TestingPrefServiceSyncable prefs;
-  VariationsService::RegisterProfilePrefs(prefs.registry());
-#else
-  TestingPrefServiceSimple prefs;
-  VariationsService::RegisterPrefs(prefs.registry());
-#endif
+TEST_F(VariationsServiceTest, GetVariationsServerURL) {
+  TestVariationsPrefsStore prefs_store;
+  PrefService* prefs = prefs_store.prefs();
   const std::string default_variations_url =
       VariationsService::GetDefaultVariationsServerURLForTesting();
 
   std::string value;
-  GURL url = VariationsService::GetVariationsServerURL(&prefs);
+  GURL url = VariationsService::GetVariationsServerURL(prefs, std::string());
   EXPECT_TRUE(StartsWithASCII(url.spec(), default_variations_url, true));
   EXPECT_FALSE(net::GetValueForKeyInQuery(url, "restrict", &value));
 
-  prefs.SetString(prefs::kVariationsRestrictParameter, "restricted");
-  url = VariationsService::GetVariationsServerURL(&prefs);
+  prefs_store.SetVariationsRestrictParameterPolicyValue("restricted");
+  url = VariationsService::GetVariationsServerURL(prefs, std::string());
   EXPECT_TRUE(StartsWithASCII(url.spec(), default_variations_url, true));
   EXPECT_TRUE(net::GetValueForKeyInQuery(url, "restrict", &value));
   EXPECT_EQ("restricted", value);
-}
-#else
-class VariationsServiceTestChromeOS : public VariationsServiceTest {
- protected:
-  VariationsServiceTestChromeOS() {}
 
-  void SetUp() override {
-    cros_settings_ = chromeos::CrosSettings::Get();
-    DCHECK(cros_settings_ != NULL);
-    // Remove the real DeviceSettingsProvider and replace it with a stub that
-    // allows modifications in a test.
-    device_settings_provider_ = cros_settings_->GetProvider(
-        chromeos::kReportDeviceVersionInfo);
-    EXPECT_TRUE(device_settings_provider_ != NULL);
-    EXPECT_TRUE(cros_settings_->RemoveSettingsProvider(
-        device_settings_provider_));
-    cros_settings_->AddSettingsProvider(&stub_settings_provider_);
-  }
-
-  void TearDown() override {
-    // Restore the real DeviceSettingsProvider.
-    EXPECT_TRUE(
-        cros_settings_->RemoveSettingsProvider(&stub_settings_provider_));
-    cros_settings_->AddSettingsProvider(device_settings_provider_);
-  }
-
-  void SetVariationsRestrictParameterPolicyValue(std::string value) {
-    cros_settings_->SetString(chromeos::kVariationsRestrictParameter, value);
-  }
-
- private:
-  chromeos::CrosSettings* cros_settings_;
-  chromeos::StubCrosSettingsProvider stub_settings_provider_;
-  chromeos::CrosSettingsProvider* device_settings_provider_;
-
-  DISALLOW_COPY_AND_ASSIGN(VariationsServiceTestChromeOS);
-};
-
-TEST_F(VariationsServiceTestChromeOS, VariationsURLIsValid) {
-  TestingPrefServiceSimple prefs;
-  VariationsService::RegisterPrefs(prefs.registry());
-  const std::string default_variations_url =
-      VariationsService::GetDefaultVariationsServerURLForTesting();
-
-  std::string value;
-  GURL url = VariationsService::GetVariationsServerURL(&prefs);
-  EXPECT_TRUE(StartsWithASCII(url.spec(), default_variations_url, true));
-  EXPECT_FALSE(net::GetValueForKeyInQuery(url, "restrict", &value));
-
-  SetVariationsRestrictParameterPolicyValue("restricted");
-  url = VariationsService::GetVariationsServerURL(&prefs);
+  // The override value should take precedence over what's in prefs.
+  url = VariationsService::GetVariationsServerURL(prefs, "override");
   EXPECT_TRUE(StartsWithASCII(url.spec(), default_variations_url, true));
   EXPECT_TRUE(net::GetValueForKeyInQuery(url, "restrict", &value));
-  EXPECT_EQ("restricted", value);
+  EXPECT_EQ("override", value);
 }
-#endif
 
 TEST_F(VariationsServiceTest, VariationsURLHasOSNameParam) {
   TestingPrefServiceSimple prefs;
   VariationsService::RegisterPrefs(prefs.registry());
-  const GURL url = VariationsService::GetVariationsServerURL(&prefs);
+  const GURL url =
+      VariationsService::GetVariationsServerURL(&prefs, std::string());
 
   std::string value;
   EXPECT_TRUE(net::GetValueForKeyInQuery(url, "osname", &value));
   EXPECT_FALSE(value.empty());
 }
 
 TEST_F(VariationsServiceTest, RequestsInitiallyNotAllowed) {
   base::MessageLoopForUI message_loop;
   content::TestBrowserThread ui_thread(content::BrowserThread::UI,
                                        &message_loop);
@@ skipping 35 matching lines @@
 
 TEST_F(VariationsServiceTest, SeedStoredWhenOKStatus) {
   base::MessageLoop message_loop;
   content::TestBrowserThread io_thread(content::BrowserThread::IO,
                                        &message_loop);
   TestingPrefServiceSimple prefs;
   VariationsService::RegisterPrefs(prefs.registry());
 
   TestVariationsService service(
       new web_resource::TestRequestAllowedNotifier(&prefs), &prefs);
-  const GURL url = VariationsService::GetVariationsServerURL(&prefs);
-  service.variations_server_url_ = url;
+  service.variations_server_url_ =
+      VariationsService::GetVariationsServerURL(&prefs, std::string());
   service.set_intercepts_fetch(false);
 
   net::TestURLFetcherFactory factory;
   service.DoActualFetch();
 
   net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
   SimulateServerResponse(net::HTTP_OK, fetcher);
   fetcher->SetResponseString(SerializeSeed(CreateTestSeed()));
 
   EXPECT_FALSE(service.seed_stored());
@@ skipping 11 matching lines @@
   };
 
   base::MessageLoop message_loop;
   content::TestBrowserThread io_thread(content::BrowserThread::IO,
                                        &message_loop);
   TestingPrefServiceSimple prefs;
   VariationsService::RegisterPrefs(prefs.registry());
 
   VariationsService service(
       new web_resource::TestRequestAllowedNotifier(&prefs), &prefs, NULL);
-  const GURL url = VariationsService::GetVariationsServerURL(&prefs);
-  service.variations_server_url_ = url;
+  service.variations_server_url_ =
+      VariationsService::GetVariationsServerURL(&prefs, std::string());
   for (size_t i = 0; i < arraysize(non_ok_status_codes); ++i) {
     net::TestURLFetcherFactory factory;
     service.DoActualFetch();
     EXPECT_TRUE(prefs.FindPreference(prefs::kVariationsSeed)->IsDefaultValue());
 
     net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
     SimulateServerResponse(non_ok_status_codes[i], fetcher);
     service.OnURLFetchComplete(fetcher);
 
     EXPECT_TRUE(prefs.FindPreference(prefs::kVariationsSeed)->IsDefaultValue());
   }
 }
 
 TEST_F(VariationsServiceTest, SeedDateUpdatedOn304Status) {
   base::MessageLoop message_loop;
   content::TestBrowserThread io_thread(content::BrowserThread::IO,
                                        &message_loop);
   TestingPrefServiceSimple prefs;
   VariationsService::RegisterPrefs(prefs.registry());
 
   net::TestURLFetcherFactory factory;
   VariationsService service(
       new web_resource::TestRequestAllowedNotifier(&prefs), &prefs, NULL);
-  const GURL url = VariationsService::GetVariationsServerURL(&prefs);
-  service.variations_server_url_ = url;
+  service.variations_server_url_ =
+      VariationsService::GetVariationsServerURL(&prefs, std::string());
   service.DoActualFetch();
   EXPECT_TRUE(
       prefs.FindPreference(prefs::kVariationsSeedDate)->IsDefaultValue());
 
   net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
   SimulateServerResponse(net::HTTP_NOT_MODIFIED, fetcher);
   service.OnURLFetchComplete(fetcher);
   EXPECT_FALSE(
       prefs.FindPreference(prefs::kVariationsSeedDate)->IsDefaultValue());
 }
@@ skipping 37 matching lines @@
     EXPECT_EQ(cases[i].expected_best_effort_notifications,
               observer.best_effort_changes_notified()) << i;
     EXPECT_EQ(cases[i].expected_crtical_notifications,
               observer.crticial_changes_notified()) << i;
 
     service.RemoveObserver(&observer);
   }
 }
 
 }  // namespace chrome_variations