Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 883693006: Fixing inbox test by adding sha1 files and enabling inbox benchmark again. (Closed)

Created:
5 years, 10 months ago by manisharora
Modified:
5 years, 10 months ago
CC:
mayankgupta, rachit_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing inbox test by adding sha1 files and enabling inbox benchmark again. BUG=452257 Committed: https://crrev.com/fd0b94cd15337a91d167a3b931ac4252e1174042 Cr-Commit-Position: refs/heads/master@{#314164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M tools/perf/benchmarks/inbox_benchmark.py View 1 chunk +11 lines, -13 lines 0 comments Download
A tools/perf/page_sets/data/inbox_credentials.json.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/inbox_data_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
manisharora
5 years, 10 months ago (2015-02-02 11:00:09 UTC) #2
tonyg
lgtm
5 years, 10 months ago (2015-02-02 17:53:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883693006/1
5 years, 10 months ago (2015-02-02 17:53:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 17:58:03 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd0b94cd15337a91d167a3b931ac4252e1174042 Cr-Commit-Position: refs/heads/master@{#314164}
5 years, 10 months ago (2015-02-02 17:59:17 UTC) #8
oystein (OOO til 10th of July)
5 years, 10 months ago (2015-02-03 02:12:55 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/893073005/ by oysteine@chromium.org.

The reason for reverting is: Still flaky on Mac 10.9 Perf (5).

Powered by Google App Engine
This is Rietveld 408576698