Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/perf/benchmarks/inbox_benchmark.py

Issue 883693006: Fixing inbox test by adding sha1 files and enabling inbox benchmark again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/data/inbox_credentials.json.sha1 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/inbox_benchmark.py
diff --git a/tools/perf/benchmarks/inbox_benchmark.py b/tools/perf/benchmarks/inbox_benchmark.py
index a79e87f2b1198a764a5205b27c3861d25c52305f..33565b6d3f46609cc747d208113ea5dc31fbeb86 100644
--- a/tools/perf/benchmarks/inbox_benchmark.py
+++ b/tools/perf/benchmarks/inbox_benchmark.py
@@ -2,16 +2,14 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# TODO: Benchmark is failing; see crbug.com/452257. Comment out instead of
-# disabling because the failure happens before the Disabled check.
-#from page_sets import inbox
-#from telemetry import benchmark
-#from telemetry.web_perf import timeline_based_measurement
-#
-#@benchmark.Disabled('android')
-#class Inbox(benchmark.Benchmark):
-# """Runs the timeline based measurement against inbox pageset."""
-# test = timeline_based_measurement.TimelineBasedMeasurement
-#
-# def CreatePageSet(self, options):
-# return inbox.InboxPageSet()
+from page_sets import inbox
+from telemetry import benchmark
+from telemetry.web_perf import timeline_based_measurement
+
+@benchmark.Disabled('android')
+class Inbox(benchmark.Benchmark):
+ """Runs the timeline based measurement against inbox pageset."""
+ test = timeline_based_measurement.TimelineBasedMeasurement
+
+ def CreatePageSet(self, options):
+ return inbox.InboxPageSet()
« no previous file with comments | « no previous file | tools/perf/page_sets/data/inbox_credentials.json.sha1 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698