Pass default renderer factory into CreateMediaRendererFactory

content/public/renderer/content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/renderer/content_renderer_client.h"
 
 #include "media/base/renderer_factory.h"
+#include "media/filters/default_renderer_factory.h"
 #include "third_party/WebKit/public/web/WebPluginPlaceholder.h"
 
 namespace content {
 
 SkBitmap* ContentRendererClient::GetSadPluginBitmap() {
   return nullptr;
 }
 
 SkBitmap* ContentRendererClient::GetSadWebViewBitmap() {
   return nullptr;
@@ skipping 150 matching lines @@
 
 bool ContentRendererClient::AllowPepperMediaStreamAPI(const GURL& url) {
   return false;
 }
 
 void ContentRendererClient::AddKeySystems(
     std::vector<media::KeySystemInfo>* key_systems) {
 }
 
 scoped_ptr<media::RendererFactory>
-ContentRendererClient::CreateMediaRendererFactory(RenderFrame* render_frame) {
-  return nullptr;
+ContentRendererClient::CreateMediaRendererFactory(
+    RenderFrame* render_frame,
+    scoped_ptr<media::DefaultRendererFactory> default_factory) {
+  scoped_ptr<media::RendererFactory> factory(default_factory.Pass());
+  return factory.Pass();

[gunsch, 2015/02/12 01:19:34]

I think this can just be:

return default_factory.PassAs<media::RendererFactory>();

[servolk, 2015/02/12 02:20:26]

Hmm, I can't find scoped_ptr::PassAs method. The only reference I could find is
in some comments for WebRtc's scoped_ptr
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...).
PassAs is not found anywhere under base/
Is that something new that hasn't made it to base/ from webrtc yet or is it
something deprecated?

[gunsch, 2015/02/12 03:18:51]

Oh, I think you can just use Pass now without the downcast step:
https://codereview.chromium.org/655143002

[servolk, 2015/02/17 18:55:05]

Done.

 }
 
 bool ContentRendererClient::ShouldReportDetailedMessageForSource(
     const base::string16& source) const {
   return false;
 }
 
 bool ContentRendererClient::ShouldEnableSiteIsolationPolicy() const {
   return true;
 }
@@ skipping 17 matching lines @@
     const std::string& mime_type,
     const GURL& original_url) {
   return nullptr;
 }
 
 std::string ContentRendererClient::GetUserAgentOverrideForURL(const GURL& url) {
   return std::string();
 }
 
 }  // namespace content