Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 655143002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
benquan, browser-components-watch_chromium.org, chromium-reviews, Dane Wallinga, dyu1, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, maniscalco+watch_chromium.org, mkwst+watchlist_chromium.org, pvalenzuela+watch_chromium.org, rouslan+autofillwatch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/1d86a70bf1953d03cf77ffb9ce90f4bb81340f79 Cr-Commit-Position: refs/heads/master@{#299703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -61 lines) Patch
M components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distiller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/dom_distiller_store_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/dom_distiller/standalone/content_extractor.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/gcm_driver/gcm_account_mapper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/infobars/test/infobar_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/password_manager/core/browser/password_generation_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_syncable_service_unittest.cc View 8 chunks +23 lines, -28 lines 0 comments Download
M components/policy/core/common/mac_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/policy/core/common/registry_dict_win.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/search_engines/template_url_service_sync_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M components/sync_driver/fake_generic_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/generic_change_processor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Just some clean up.
6 years, 2 months ago (2014-10-15 05:44:45 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-15 15:26:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655143002/1
6 years, 2 months ago (2014-10-15 17:13:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 17:27:09 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 17:27:54 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1d86a70bf1953d03cf77ffb9ce90f4bb81340f79
Cr-Commit-Position: refs/heads/master@{#299703}

Powered by Google App Engine
This is Rietveld 408576698