Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: Source/core/rendering/RenderRegion.h

Issue 883293004: [New Multicolumn] Preparatory work for nested multicol support. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Place the new files in ../layout/ , since that's where they'll end up soon anyway. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderRegion.h
diff --git a/Source/core/rendering/RenderRegion.h b/Source/core/rendering/RenderRegion.h
index fbd3711f363a5ee7886ae8a807afb7859ea7a8a0..a48ed5ffd8138e02f3a771cdc68dfee8984b7e7c 100644
--- a/Source/core/rendering/RenderRegion.h
+++ b/Source/core/rendering/RenderRegion.h
@@ -42,9 +42,9 @@ public:
virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectRenderRegion || RenderBlockFlow::isOfType(type); }
- void setFlowThreadPortionRect(const LayoutRect& rect) { m_flowThreadPortionRect = rect; }
- LayoutRect flowThreadPortionRect() const { return m_flowThreadPortionRect; }
+ virtual LayoutRect flowThreadPortionRect() const = 0;
LayoutRect flowThreadPortionOverflowRect() const;
+ LayoutRect overflowRectForFlowThreadPortion(const LayoutRect& flowThreadPortionRect, bool isFirstPortion, bool isLastPortion) const;
RenderFlowThread* flowThread() const { return m_flowThread; }
@@ -69,8 +69,6 @@ public:
protected:
virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const override final;
- LayoutRect overflowRectForFlowThreadPortion(const LayoutRect& flowThreadPortionRect, bool isFirstPortion, bool isLastPortion) const;
-
private:
virtual void layoutBlock(bool relayoutChildren) override final;
@@ -78,7 +76,6 @@ protected:
RenderFlowThread* m_flowThread;
private:
- LayoutRect m_flowThreadPortionRect;
bool m_isValid : 1;
};
« Source/core/rendering/RenderFlowThread.cpp ('K') | « Source/core/rendering/RenderMultiColumnSet.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698