Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 883163005: Do not broadcast fileManagerPrivate.onDirectoryChanged event. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not broadcast fileManagerPrivate.onDirectoryChanged event. Since onDirectoryChanged event is created for each extension, we should not broadcast it. BUG=456046 TEST=none Committed: https://crrev.com/82eb39ef448c9cab8020804a9e196f631c9afe05 Cr-Commit-Position: refs/heads/master@{#315258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-06 11:03:50 UTC) #2
mtomasz
lgtm
5 years, 10 months ago (2015-02-09 02:28:28 UTC) #3
yawano
On 2015/02/09 02:28:28, mtomasz wrote: > lgtm Thank you!
5 years, 10 months ago (2015-02-09 02:28:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883163005/1
5 years, 10 months ago (2015-02-09 02:29:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 02:55:13 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 02:55:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82eb39ef448c9cab8020804a9e196f631c9afe05
Cr-Commit-Position: refs/heads/master@{#315258}

Powered by Google App Engine
This is Rietveld 408576698