Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/event_router.cc

Issue 883163005: Do not broadcast fileManagerPrivate.onDirectoryChanged event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_manager/event_router.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/event_router.cc b/chrome/browser/chromeos/extensions/file_manager/event_router.cc
index f1ceb0fed9c41b335e0a38e6e2cb54f80d2cd63c..9f76f51b5faf47be33bf286e8f2d668f1469a903 100644
--- a/chrome/browser/chromeos/extensions/file_manager/event_router.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/event_router.cc
@@ -154,6 +154,17 @@ void BroadcastEvent(Profile* profile,
make_scoped_ptr(new extensions::Event(event_name, event_args.Pass())));
}
+// Sends an event named |event_name| with arguments |event_args| to an extension
+// of |extention_id|.
+void DispatchEventToExtension(Profile* profile,
+ const std::string& extension_id,
+ const std::string& event_name,
+ scoped_ptr<base::ListValue> event_args) {
+ extensions::EventRouter::Get(profile)->DispatchEventToExtension(
+ extension_id,
+ make_scoped_ptr(new extensions::Event(event_name, event_args.Pass())));
+}
+
file_manager_private::MountCompletedStatus
MountErrorToMountCompletedStatus(chromeos::MountError error) {
switch (error) {
@@ -940,9 +951,11 @@ void EventRouter::DispatchDirectoryChangeEventWithEntryDefinition(
event.entry.additional_properties.SetBoolean("fileIsDirectory",
entry_definition.is_directory);
- BroadcastEvent(profile_,
- file_manager_private::OnDirectoryChanged::kEventName,
- file_manager_private::OnDirectoryChanged::Create(event));
+ DispatchEventToExtension(
+ profile_,
+ *extension_id,
+ file_manager_private::OnDirectoryChanged::kEventName,
+ file_manager_private::OnDirectoryChanged::Create(event));
}
void EventRouter::OnDiskAdded(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698