Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 883063003: Revert of Fix shelf dimming on secondary display (Closed)

Created:
5 years, 10 months ago by achaulk
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix shelf dimming on secondary display (patchset #1 id:40001 of https://codereview.chromium.org/850833004/) Reason for revert: Causing crbug.com/451804 - probably using an invalid window Original issue's description: > Fix shelf dimming on secondary display > > BUG=449863 > TEST=ShelfLayoutManagerTest.DimmingBehaviorDualDisplay > > Committed: https://crrev.com/665d66d93fe22a50ba3623397b596a394098faef > Cr-Commit-Position: refs/heads/master@{#312244} TBR=skuhne@chromium.org,pkotwicz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449863 Committed: https://crrev.com/d9f6557e6515dd693acc620afdb87849a0f03c97 Cr-Commit-Position: refs/heads/master@{#313787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -69 lines) Patch
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +2 lines, -57 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 3 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
achaulk
Created Revert of Fix shelf dimming on secondary display
5 years, 10 months ago (2015-01-29 17:27:41 UTC) #1
achaulk
not a committer so i need an lgtm from somebody
5 years, 10 months ago (2015-01-29 17:28:49 UTC) #3
pkotwicz
lgtm
5 years, 10 months ago (2015-01-29 20:58:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883063003/1
5 years, 10 months ago (2015-01-29 21:00:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 21:01:20 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d9f6557e6515dd693acc620afdb87849a0f03c97 Cr-Commit-Position: refs/heads/master@{#313787}
5 years, 10 months ago (2015-01-29 21:02:33 UTC) #8
Mr4D (OOO till 08-26)
5 years, 10 months ago (2015-01-29 21:43:46 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698