Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 882813005: Respect the smooth scrolling setting in LayerScrollableArea. (Closed)

Created:
5 years, 10 months ago by skobes
Modified:
5 years, 10 months ago
Reviewers:
ajuma, Nate Chapin
CC:
blink-reviews, blink-layers+watch_chromium.org, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering, weiliangc
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland: Respect the smooth scrolling setting in LayerScrollableArea. This relands https://blink.lc/blink/commit/?id=5668429, which was reverted in https://blink.lc/blink/commit/?id=a1303a8. The Mac trackpad regression is addressed by https://blink.lc/blink/commit/?id=021397d. BUG=575, 417782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190675

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : update test to check animation duration #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -57 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/overflow-scroll-animates.html View 1 2 3 1 chunk +85 lines, -0 lines 0 comments Download
A + LayoutTests/fast/scroll-behavior/overflow-scroll-animates-expected.txt View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
D LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/scroll-behavior/precise-delta-no-animate-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/layout/LayerScrollableArea.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayerScrollableArea.cpp View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
skobes
5 years, 10 months ago (2015-01-31 01:04:58 UTC) #4
ajuma
lgtm
5 years, 10 months ago (2015-02-02 14:43:03 UTC) #5
skobes
There's something wrong with the animations here that I need to look into before landing ...
5 years, 10 months ago (2015-02-04 23:54:08 UTC) #6
skobes
+japhet for Source/web OWNERS The slow animation issue is fixed by http://crrev.com/905463007 and I have ...
5 years, 10 months ago (2015-02-10 03:46:29 UTC) #9
Nate Chapin
lgtm
5 years, 10 months ago (2015-02-11 17:52:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882813005/120001
5 years, 10 months ago (2015-02-11 21:11:16 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:120001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190002
5 years, 10 months ago (2015-02-11 22:22:56 UTC) #13
ccameron
A revert of this CL (patchset #4 id:120001) has been created in https://codereview.chromium.org/933823004/ by ccameron@chromium.org. ...
5 years, 10 months ago (2015-02-18 21:54:24 UTC) #14
skobes
Mac regression fixed in http://crrev.com/941843002, relanding.
5 years, 10 months ago (2015-02-23 18:24:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882813005/140001
5 years, 10 months ago (2015-02-23 18:25:35 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 18:37:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190675

Powered by Google App Engine
This is Rietveld 408576698