Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 882813002: Observe UsbService from the FILE thread in DevicePermissionsManager. (Closed)

Created:
5 years, 11 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 10 months ago
Reviewers:
scheib
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Observe UsbService from the FILE thread in DevicePermissionsManager. As in the UsbEventRouter the UsbService must be observed from the FILE thread (until bug 427985 is resolved, which will be soon). This change fixes a DCHECK(CalledOnValidThread()) in UsbService::AddObserver when permission to access an ephemeral (no serial number) device is added and the DevicePermissionsManager starts listening for disconnection of that device. BUG=452652 Committed: https://crrev.com/897bbc219ac773a8a6c5799bc323b9fa8eea0989 Cr-Commit-Position: refs/heads/master@{#313548}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Remove the controversial fix for bug 452298. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -14 lines) Patch
M chrome/browser/extensions/api/device_permissions_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M extensions/browser/api/device_permissions_manager.h View 4 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/api/device_permissions_manager.cc View 1 7 chunks +47 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Reilly Grant (use Gerrit)
Vince, please take a look at this patch. I'm going to have to merge it ...
5 years, 11 months ago (2015-01-27 23:45:13 UTC) #4
scheib
https://codereview.chromium.org/882813002/diff/40001/extensions/browser/api/device_permissions_manager.cc File extensions/browser/api/device_permissions_manager.cc (right): https://codereview.chromium.org/882813002/diff/40001/extensions/browser/api/device_permissions_manager.cc#newcode412 extensions/browser/api/device_permissions_manager.cc:412: base::TimeDelta::FromMinutes(5)); ಠ_ಠ
5 years, 11 months ago (2015-01-27 23:56:25 UTC) #5
Reilly Grant (use Gerrit)
On 2015/01/27 23:56:25, scheib wrote: > https://codereview.chromium.org/882813002/diff/40001/extensions/browser/api/device_permissions_manager.cc > File extensions/browser/api/device_permissions_manager.cc (right): > > https://codereview.chromium.org/882813002/diff/40001/extensions/browser/api/device_permissions_manager.cc#newcode412 > ...
5 years, 11 months ago (2015-01-28 01:00:22 UTC) #6
scheib
lgtm
5 years, 10 months ago (2015-01-28 18:32:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882813002/60001
5 years, 10 months ago (2015-01-28 18:45:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 10 months ago (2015-01-28 18:48:18 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 18:49:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/897bbc219ac773a8a6c5799bc323b9fa8eea0989
Cr-Commit-Position: refs/heads/master@{#313548}

Powered by Google App Engine
This is Rietveld 408576698