Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Unified Diff: chrome/browser/extensions/api/device_permissions_manager_unittest.cc

Issue 882813002: Observe UsbService from the FILE thread in DevicePermissionsManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove the controversial fix for bug 452298. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/device_permissions_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/device_permissions_manager_unittest.cc
diff --git a/chrome/browser/extensions/api/device_permissions_manager_unittest.cc b/chrome/browser/extensions/api/device_permissions_manager_unittest.cc
index 6ce366046a77554165751c1e0315a55bd245d632..4bac4e3fae961669b0c3284f406d5a787ac8017e 100644
--- a/chrome/browser/extensions/api/device_permissions_manager_unittest.cc
+++ b/chrome/browser/extensions/api/device_permissions_manager_unittest.cc
@@ -223,7 +223,9 @@ TEST_F(DevicePermissionsManagerTest, SuspendExtension) {
ASSERT_FALSE(FindEntry(device_permissions.get(), device3_).get());
}
-TEST_F(DevicePermissionsManagerTest, DisconnectDevice) {
+// TODO(reillyg): Until crbug.com/427985 is resolved device removal
+// notifications are delivered asynchronously and so this test must be disabled.
+TEST_F(DevicePermissionsManagerTest, DISABLED_DisconnectDevice) {
DevicePermissionsManager* manager =
DevicePermissionsManager::Get(env_.profile());
AllowUsbDevice(manager, extension_, device0_);
« no previous file with comments | « no previous file | extensions/browser/api/device_permissions_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698