Issue 882723003: Make it possible to navigate <iframes>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 882723003: Make it possible to navigate <iframes> (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make it possible to navigate <iframes> Also, add support for exposing services to <iframes>. This worked before but now that [Client=...] is gone we need to create another message pipe. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/08640aaedb938d514fda7d23e37f574e3f954ced

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -20 lines)			Patch
M	sky/engine/core/html/HTMLIFrameElement.h	View		1 chunk	+9 lines, -6 lines	0 comments	Download
M	sky/engine/core/html/HTMLIFrameElement.cpp	View		3 chunks	+29 lines, -13 lines	0 comments	Download
M	sky/engine/core/html/HTMLIFrameElement.idl	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	sky/tests/services/iframe-service-provider.sky	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
A	sky/tests/services/iframe-service-provider-expected.txt	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 11 months ago (2015-01-27 18:35:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
08640aaedb938d514fda7d23e37f574e3f954ced (presubmit successful).