Make it possible to navigate <iframes>

sky/engine/core/html/HTMLIFrameElement.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sky/engine/config.h"
 #include "sky/engine/core/html/HTMLIFrameElement.h"
 
 #include "gen/sky/core/HTMLNames.h"
 #include "mojo/edk/js/handle.h"
 #include "sky/engine/core/frame/LocalFrame.h"
@@ skipping 16 matching lines @@
 
 HTMLIFrameElement::~HTMLIFrameElement()
 {
     if (m_contentView)
         m_contentView->RemoveObserver(this);
 }
 
 void HTMLIFrameElement::insertedInto(ContainerNode* insertionPoint)
 {
     HTMLElement::insertedInto(insertionPoint);
-    if (insertionPoint->inDocument())
-        createView();
+    if (insertionPoint->inDocument()) {
+        if (LocalFrame* frame = document().frame())
+            m_contentView = frame->loaderClient()->createChildFrame();
+        navigateView();
+    }
 }
 
 void HTMLIFrameElement::removedFrom(ContainerNode* insertionPoint)
 {
     HTMLElement::removedFrom(insertionPoint);
     if (m_contentView)
         m_contentView->Destroy();
 }
 
+void HTMLIFrameElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
+{
+    if (name == HTMLNames::srcAttr) {
+        navigateView();
+    } else {
+        HTMLElement::parseAttribute(name, value);
+    }
+}
+
 RenderObject* HTMLIFrameElement::createRenderer(RenderStyle* style)
 {
     return new RenderIFrame(this);
 }
 
 void HTMLIFrameElement::OnViewDestroyed(mojo::View* view)
 {
     DCHECK_EQ(view, m_contentView);
     m_contentView = nullptr;
 }
 
-ScriptValue HTMLIFrameElement::takeServiceProvider(ScriptState* scriptState)
+ScriptValue HTMLIFrameElement::takeServicesHandle(ScriptState* scriptState)
 {
     return ScriptValue(scriptState, gin::ConvertToV8(scriptState->isolate(), m_services.PassMessagePipe().release()));
 }
 
-void HTMLIFrameElement::createView()
+ScriptValue HTMLIFrameElement::takeExposedServicesHandle(ScriptState* scriptState)
 {
+    return ScriptValue(scriptState, gin::ConvertToV8(scriptState->isolate(), m_exposedServices.release()));
+}
+
+void HTMLIFrameElement::navigateView()
+{
+    if (!m_contentView)
+        return;
+
     String urlString = stripLeadingAndTrailingHTMLSpaces(getAttribute(HTMLNames::srcAttr));
     if (urlString.isEmpty())
         urlString = blankURL().string();
 
-    LocalFrame* parentFrame = document().frame();
-    if (!parentFrame)
-        return;
+    KURL url = document().completeURL(urlString);
 
-    KURL url = document().completeURL(urlString);
-    m_contentView = parentFrame->loaderClient()->createChildFrame();
-    if (!m_contentView)
-        return;
+    mojo::MessagePipe exposedServicesPipe;
+    m_exposedServices = exposedServicesPipe.handle0.Pass();
 
     m_contentView->Embed(mojo::String::From(url.string().utf8().data()),
-        GetProxy(&m_services),
-        nullptr);  // TODO(abarth) Expose the exposedService parameter.
+        mojo::GetProxy(&m_services),
+        mojo::MakeProxy<mojo::ServiceProvider>(exposedServicesPipe.handle1.Pass()));
     m_contentView->AddObserver(this);
 }
 
 }