Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 882503002: [PATCH 9.2/11] ozone: evdev: Use DeviceEventDispatcherEvdev from InputInjectorEvdev (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Use DeviceEventDispatcherEvdev from InputInjectorEvdev This makes the injector use the same interface as the devices themselves. It also allows us to remove the PostTask after ui::Event construction from EventFactoryEvdev, because all dispatches already start in their own task (posted by ForwardingDeviceEventDispatcher). BUG=449710 TEST=boot link_freon & move mouse Committed: https://crrev.com/72486d99c52d26ee06446115644d1d2ab7b34efd Cr-Commit-Position: refs/heads/master@{#313878}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -66 lines) Patch
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/input_injector_evdev.h View 2 chunks +5 lines, -14 lines 0 comments Download
M ui/events/ozone/evdev/input_injector_evdev.cc View 1 3 chunks +32 lines, -42 lines 0 comments Download
M ui/events/ozone/evdev/input_injector_evdev_unittest.cc View 1 3 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
spang
5 years, 10 months ago (2015-01-26 22:43:53 UTC) #2
spang
5 years, 10 months ago (2015-01-27 19:34:56 UTC) #3
alexst (slow to review)
lgtm
5 years, 10 months ago (2015-01-28 18:41:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882503002/60001
5 years, 10 months ago (2015-01-30 06:26:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882503002/60001
5 years, 10 months ago (2015-01-30 06:59:01 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-30 07:08:25 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 07:09:07 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/72486d99c52d26ee06446115644d1d2ab7b34efd
Cr-Commit-Position: refs/heads/master@{#313878}

Powered by Google App Engine
This is Rietveld 408576698