Issue 88243003: Linux sandbox: move CurrentProcessHasOpenDirectories

Issue 88243003: Linux sandbox: move CurrentProcessHasOpenDirectories (Closed)

Created:
7 years ago by jln (very slow on Chromium)

Modified:
7 years ago

Reviewers:
Jorge Lucangeli Obes, Michael Moss, mmoss

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, agl, jln+watch_chromium.org, Jorge Lucangeli Obes

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Linux sandbox: move CurrentProcessHasOpenDirectories Move CurrentProcessHasOpenDirectories() to the Credentials class and rename it to HasOpenDirectory(). Also add some unittests. This is a re-land of https://codereview.chromium.org/85403011/. BUG=312380 R=jorgelo@chromium.org, mmoss@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237390

Patch Set 2 : Add dependencies #

Total comments: 2

Patch Set 3 : Add dependencies #

Patch Set 4 : rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -59 lines)			Patch
M	chrome/installer/linux/debian/expected_deps	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/linux/rpm/expected_deps_i386	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/linux/rpm/expected_deps_x86_64	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/sandbox_linux.cc	View		3 chunks	+2 lines, -56 lines	0 comments	Download
M	sandbox/linux/services/credentials.h	View		2 chunks	+16 lines, -3 lines	0 comments	Download
M	sandbox/linux/services/credentials.cc	View		4 chunks	+61 lines, -0 lines	0 comments	Download
M	sandbox/linux/services/credentials_unittest.cc	View		2 chunks	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jln (very slow on Chromium)

Michael: please take a look! PS#1 is as reviewed by jorgelo@ PS#2 adds the required ...

7 years ago (2013-11-26 19:03:33 UTC) #1

mmoss

https://codereview.chromium.org/88243003/diff/20001/chrome/installer/linux/rpm/expected_deps_x86_64 File chrome/installer/linux/rpm/expected_deps_x86_64 (right): https://codereview.chromium.org/88243003/diff/20001/chrome/installer/linux/rpm/expected_deps_x86_64#newcode6 chrome/installer/linux/rpm/expected_deps_x86_64:6: libcap.so.2(64bit) I think this should be: libcap.so.2()(64bit)

7 years ago (2013-11-26 19:06:33 UTC) #3

jln (very slow on Chromium)

7 years ago (2013-11-26 19:07:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r237390.

Expand Messages | Collapse Messages