Linux sandbox: move CurrentProcessHasOpenDirectories

Linux sandbox: move CurrentProcessHasOpenDirectories

Move CurrentProcessHasOpenDirectories() to the Credentials class and rename
it to HasOpenDirectory().
Also add some unittests.

BUG=312380
R=jorgelo@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237242

[jln (very slow on Chromium), 2013-11-26 01:33:27]

Jorge, please take a look!

[Jorge Lucangeli Obes, 2013-11-26 01:45:27]

https://codereview.chromium.org/85403011/diff/1/sandbox/linux/services/creden...
File sandbox/linux/services/credentials.cc (right):

https://codereview.chromium.org/85403011/diff/1/sandbox/linux/services/creden...
sandbox/linux/services/credentials.cc:164: proc_self_fd = openat(AT_FDCWD,
"/proc/self/fd", O_DIRECTORY | O_RDONLY);
Any reason to use openat() for the absolute path case?

https://codereview.chromium.org/85403011/diff/1/sandbox/linux/services/creden...
sandbox/linux/services/credentials.cc:167: // TODO(mostynb@opera.com): add a
CHECK_EQ(ENOENT, errno); Figure out what
Are you specifically adding a TODO for someone else?

[jln (very slow on Chromium), 2013-11-26 01:52:17]

https://codereview.chromium.org/85403011/diff/1/sandbox/linux/services/creden...
File sandbox/linux/services/credentials.cc (right):

https://codereview.chromium.org/85403011/diff/1/sandbox/linux/services/creden...
sandbox/linux/services/credentials.cc:164: proc_self_fd = openat(AT_FDCWD,
"/proc/self/fd", O_DIRECTORY | O_RDONLY);
On 2013/11/26 01:45:27, Jorge Lucangeli Obes wrote:
> Any reason to use openat() for the absolute path case?

I'm moving existing code. But the reason for this is that the call is much more
symmetric this way between the case where proc_fd is supplied and when it's not,
which in general is a very good idea for these kinds of construct.

For instance if some crazy hook was modifying open() calls and not openat(), our
code would still behave the same regardless of |proc_fd|

https://codereview.chromium.org/85403011/diff/1/sandbox/linux/services/creden...
sandbox/linux/services/credentials.cc:167: // TODO(mostynb@opera.com): add a
CHECK_EQ(ENOENT, errno); Figure out what
On 2013/11/26 01:45:27, Jorge Lucangeli Obes wrote:
> Are you specifically adding a TODO for someone else?

Just moving existing code.

[Jorge Lucangeli Obes, 2013-11-26 01:53:41]

lgtm

[jln (very slow on Chromium), 2013-11-26 03:33:36]

Committed patchset #1 manually as r237242.

[jln (very slow on Chromium), 2013-11-26 04:12:15]

On 2013/11/26 03:33:36, jln wrote:
> Committed patchset #1 manually as r237242.

This was somehow the first time capabilities.cc was actually needed to link
content/ and something weird happened on the "Official" bot:

FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a x64
-c stable
Staging common install files in '/tmp/rpm.build.WSrMSY'...
Staging RPM install files in '/tmp/rpm.build.WSrMSY'...
Packaging x86_64...
5a6
> libcap.so.2()(64bit)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/rpm/expected_deps_i386
chrome/installer/linux/rpm/expected_deps_x86_64

FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a
x64 -c unstable
5a6
> libcap2 (>= 2.10)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps

Cleaning...
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a
x64 -c beta
5a6
> libcap2 (>= 2.10)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps

Cleaning...
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a
x64 -c stable
5a6
> libcap2 (>= 2.10)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps

Cleaning...
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a x64
-c beta
Staging common install files in '/tmp/rpm.build.Xm3oJk'...
Staging RPM install files in '/tmp/rpm.build.Xm3oJk'...
Packaging x86_64...
5a6
> libcap.so.2()(64bit)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/rpm/expected_deps_i386
chrome/installer/linux/rpm/expected_deps_x86_64

../out/Release/chrome, section '.eh_frame': the call frame entry at offset
0x91e648 uses a DWARF expression to describe how to recover register '.cfa', 
but this translator cannot yet translate DWARF expressions to Breakpad postfix
expressions
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a x64
-c unstable
Staging common install files in '/tmp/rpm.build.njSkFA'...
Staging RPM install files in '/tmp/rpm.build.njSkFA'...
Packaging x86_64...
5a6
> libcap.so.2()(64bit)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/rpm/expected_deps_i386
chrome/installer/linux/rpm/expected_deps_x86_64