Issue 88233003: Code cleanup following recapture of skps

Issue 88233003: Code cleanup following recapture of skps (Closed)

Created:
7 years ago by robertphillips

Modified:
7 years ago

Reviewers:
mtklein, reed1

CC:
skia-review_googlegroups.com, rmistry

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Code cleanup following recapture of skps

Patch Set 5 : More cleanup #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -65 lines)			Patch
M	include/core/SkPath.h	View	1 2 3	1 chunk	+3 lines, -8 lines	0 comments	Download
M	include/core/SkPicture.h	View	1 2 3 4	1 chunk	+1 line, -7 lines	0 comments	Download
M	src/core/SkPath.cpp	View	1 2 3	2 chunks	+2 lines, -5 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	1 2 3 4	1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	1 2	1 chunk	+1 line, -12 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	1 2 3	2 chunks	+4 lines, -12 lines	0 comments	Download
M	src/effects/SkEmbossMaskFilter.cpp	View	1 2 3	2 chunks	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm https://codereview.chromium.org/88233003/diff/20001/include/core/SkPath.h File include/core/SkPath.h (right): https://codereview.chromium.org/88233003/diff/20001/include/core/SkPath.h#newcode935 include/core/SkPath.h:935: kUnused_SerializationShift = 25, // requires 1 bit maybe ...

7 years ago (2013-11-26 14:26:24 UTC) #2

robertphillips

PTAL. I had to back off on the cleanup b.c. of https://codereview.chromium.org/89123002/ (Move fIsOval from ...

7 years ago (2013-12-03 19:36:47 UTC) #4

mtklein

On 2013/12/03 19:36:47, robertphillips wrote: > PTAL. I had to back off on the cleanup ...

7 years ago (2013-12-03 19:44:08 UTC) #5

Message was sent while issue was closed.

committed as r12472

Expand Messages | Collapse Messages