Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 882243004: web_dev_style: allow 0ms or 0s while we hash out the breakage of crbug.com/454776 (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

web_dev_style: allow 0ms or 0s while we hash out the breakage of crbug.com/454776 R=arv@chromium.org BUG=454776 Committed: https://crrev.com/d19579d57340b6bd42eb34237ae193ace1fa7172 Cr-Commit-Position: refs/heads/master@{#314353}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M chrome/browser/test_presubmit.py View 3 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/web_dev_style/css_checker.py View 2 chunks +8 lines, -9 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Dan Beam
we can always revert if the blink rev doesn't stick https://codereview.chromium.org/882243004/diff/1/chrome/browser/web_dev_style/css_checker.py File chrome/browser/web_dev_style/css_checker.py (left): https://codereview.chromium.org/882243004/diff/1/chrome/browser/web_dev_style/css_checker.py#oldcode270 ...
5 years, 10 months ago (2015-02-03 16:09:17 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 10 months ago (2015-02-03 16:11:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882243004/1
5 years, 10 months ago (2015-02-03 16:13:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 16:48:22 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 16:49:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d19579d57340b6bd42eb34237ae193ace1fa7172
Cr-Commit-Position: refs/heads/master@{#314353}

Powered by Google App Engine
This is Rietveld 408576698