Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: chrome/browser/test_presubmit.py

Issue 882243004: web_dev_style: allow 0ms or 0s while we hash out the breakage of crbug.com/454776 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/test_presubmit.py
diff --git a/chrome/browser/test_presubmit.py b/chrome/browser/test_presubmit.py
index d37a6b3e6cc72e7412adc23375971c0d587d0fd4..ac0e13b90a02258f14a6ed528451db866ef213e4 100755
--- a/chrome/browser/test_presubmit.py
+++ b/chrome/browser/test_presubmit.py
@@ -804,7 +804,7 @@ b:before,
-webkit-margin-before: 10px; (replace with margin-top)
-webkit-padding-after: 3px; (replace with padding-bottom)""")
- def testCssZeroLengthTerms(self):
+ def testCssZeroWidthLengths(self):
self.VerifyContentsProducesOutput("""
@-webkit-keyframe anim {
0% { /* Ignore key frames */
@@ -836,10 +836,7 @@ body.alternate-logo #logo {
.media-button[state='0']:not(.disabled):hover > .state0.hover {
-webkit-animation: anim 0s;
-webkit-animation-duration: anim 0ms;
- -webkit-transform: scale(0%),
- translateX(0deg),
- translateY(0rad),
- translateZ(0grad);
+ -webkit-transform: scale(0%);
background-position-x: 0em;
background-position-y: 0ex;
border-width: 0em;
@@ -854,15 +851,9 @@ body.alternate-logo #logo {
height: 0cm;
width: 0in;
}""", """
-- Make all zero length terms (i.e. 0px) 0 unless inside of hsl() or part of"""
-""" @keyframe.
+- Use "0" for zero-width lengths (i.e. 0px -> 0)
width: 0px;
- -webkit-animation: anim 0s;
- -webkit-animation-duration: anim 0ms;
- -webkit-transform: scale(0%),
- translateX(0deg),
- translateY(0rad),
- translateZ(0grad);
+ -webkit-transform: scale(0%);
background-position-x: 0em;
background-position-y: 0ex;
border-width: 0em;
« no previous file with comments | « no previous file | chrome/browser/web_dev_style/css_checker.py » ('j') | chrome/browser/web_dev_style/css_checker.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698