Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 882223005: Remove painting roots. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove painting roots. These appear to have been for ensuring that you only paint elements in a given subtree. It's not clear to me exactly how you get to painting an element that is not rooted at the RenderLayer you started with. I think it's just not possible in Sky anymore. This code was added in 2004 for drag images, which we no longer support. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6a3cff3f6958aa955a3862f92ba705be0bce1546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -105 lines) Patch
M sky/engine/core/frame/FrameView.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 4 chunks +1 line, -10 lines 0 comments Download
M sky/engine/core/rendering/InlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 3 chunks +2 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/InlineTextBox.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/LayerPaintingInfo.h View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/PaintInfo.h View 2 chunks +1 line, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 3 chunks +2 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 7 chunks +11 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderReplaced.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 10 months ago (2015-01-29 03:50:03 UTC) #2
ojan
5 years, 10 months ago (2015-01-29 03:53:48 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6a3cff3f6958aa955a3862f92ba705be0bce1546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698