Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 882223002: bluetooth: Add more attributes to WebBluetoothDevice. (Closed)

Created:
5 years, 10 months ago by scheib
Modified:
5 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@gclient
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Add more attributes to WebBluetoothDevice. Prepares for these attributes to be provided by content patch https://codereview.chromium.org/885723002 Will be followed up with a patch to expose the attributes https://codereview.chromium.org/876623003 Also, update 'instanceId' to 'instanceID' to track specification and be consistent with other ID names. BUG=421668 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189209

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -20 lines) Patch
M LayoutTests/bluetooth/idl-BluetoothDevice.html View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/modules/bluetooth/BluetoothDevice.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/bluetooth/BluetoothDevice.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/modules/bluetooth/BluetoothDevice.idl View 2 chunks +5 lines, -5 lines 0 comments Download
M public/platform/WebBluetoothDevice.h View 1 chunk +51 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
scheib
5 years, 10 months ago (2015-01-28 21:08:16 UTC) #2
Marijn Kruisselbrink
lgtm https://codereview.chromium.org/882223002/diff/1/Source/modules/bluetooth/BluetoothDevice.h File Source/modules/bluetooth/BluetoothDevice.h (right): https://codereview.chromium.org/882223002/diff/1/Source/modules/bluetooth/BluetoothDevice.h#newcode35 Source/modules/bluetooth/BluetoothDevice.h:35: static void dispose(blink::WebBluetoothDevice*); (unrelated to this CL, but ...
5 years, 10 months ago (2015-01-28 21:18:37 UTC) #3
scheib
japhet, OWNERS for public https://codereview.chromium.org/882223002/diff/1/Source/modules/bluetooth/BluetoothDevice.h File Source/modules/bluetooth/BluetoothDevice.h (right): https://codereview.chromium.org/882223002/diff/1/Source/modules/bluetooth/BluetoothDevice.h#newcode35 Source/modules/bluetooth/BluetoothDevice.h:35: static void dispose(blink::WebBluetoothDevice*); On 2015/01/28 ...
5 years, 10 months ago (2015-01-28 21:29:13 UTC) #5
Nate Chapin
lgtm
5 years, 10 months ago (2015-01-29 17:48:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882223002/20001
5 years, 10 months ago (2015-01-29 17:52:21 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:03:37 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189209

Powered by Google App Engine
This is Rietveld 408576698