Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 876623003: bluetooth: New WebBluetoothDevice attributes plumbed to BluetoothDevice. (Closed)

Created:
5 years, 10 months ago by scheib
Modified:
5 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@bt-1-
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: New WebBluetoothDevice attributes plumbed to BluetoothDevice. Completes the work started in https://codereview.chromium.org/882223002/ to expose more attributes to BluetoothDevice. Depends on https://codereview.chromium.org/885723002/ to provide the values in the response. BUG=421668 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189289

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -30 lines) Patch
M LayoutTests/bluetooth/idl-BluetoothDevice.html View 1 1 chunk +20 lines, -3 lines 0 comments Download
M Source/modules/bluetooth/BluetoothDevice.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/bluetooth/BluetoothDevice.cpp View 1 chunk +57 lines, -0 lines 0 comments Download
M Source/modules/bluetooth/BluetoothDevice.idl View 2 chunks +16 lines, -13 lines 0 comments Download
M public/platform/WebBluetoothDevice.h View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
scheib
5 years, 10 months ago (2015-01-28 21:17:22 UTC) #2
Marijn Kruisselbrink
lgtm
5 years, 10 months ago (2015-01-28 21:50:38 UTC) #3
scheib
5 years, 10 months ago (2015-01-30 00:17:32 UTC) #7
Nate Chapin
public/ LGTM
5 years, 10 months ago (2015-01-30 18:45:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876623003/60001
5 years, 10 months ago (2015-01-30 22:06:10 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 23:21:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189289

Powered by Google App Engine
This is Rietveld 408576698