Experimental scanner += API which takes Handle<String>.

src/lexer/experimental-scanner.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#include "icu_util.h"
-
-#if defined(_WIN32) && defined(V8_I18N_SUPPORT)
-#include <windows.h>
-
-#include "unicode/putil.h"
-#include "unicode/udata.h"
-
-#define ICU_UTIL_DATA_SYMBOL "icudt" U_ICU_VERSION_SHORT "_dat"
-#define ICU_UTIL_DATA_SHARED_MODULE_NAME "icudt.dll"
-#endif
+#include "experimental-scanner.h"
 
 namespace v8 {
-
 namespace internal {
 
-bool InitializeICU() {
-#if defined(_WIN32) && defined(V8_I18N_SUPPORT)
-  // We expect to find the ICU data module alongside the current module.
-  HMODULE module = LoadLibraryA(ICU_UTIL_DATA_SHARED_MODULE_NAME);
-  if (!module) return false;
+std::set<ScannerBase*>* ScannerBase::scanners_ = NULL;
 
-  FARPROC addr = GetProcAddress(module, ICU_UTIL_DATA_SYMBOL);
-  if (!addr) return false;
-
-  UErrorCode err = U_ZERO_ERROR;
-  udata_setCommonData(reinterpret_cast<void*>(addr), &err);
-  return err == U_ZERO_ERROR;
-#else
-  // Mac/Linux bundle the ICU data in.
-  return true;
-#endif
+void ScannerBase::UpdateBuffersAfterGC(v8::Isolate*, GCType, GCCallbackFlags) {
+  if (!scanners_)

[ulan, 2013/11/26 13:15:47]

Either one line "if (!scanners_) return;" or add braces.

[marja, 2013/11/26 13:35:05]

Done.

+    return;
+  for (std::set<ScannerBase*>::const_iterator it = scanners_->begin();
+       it != scanners_->end();
+       ++it)
+    (*it)->SetBufferBasedOnHandle();
 }
 
-} }  // namespace v8::internal
+template<>
+const uint8_t* ExperimentalScanner<uint8_t>::GetNewBufferBasedOnHandle() const {
+  String::FlatContent content = source_handle_->GetFlatContent();
+  return content.ToOneByteVector().start();
+}
+
+template <>

[ulan, 2013/11/26 13:15:47]

Separate functions with two empty lines.

[marja, 2013/11/26 13:35:05]

Done.

+const uint16_t* ExperimentalScanner<uint16_t>::GetNewBufferBasedOnHandle()
+    const {
+  String::FlatContent content = source_handle_->GetFlatContent();
+  return content.ToUC16Vector().start();
+}
+
+
+template<>
+const int8_t* ExperimentalScanner<int8_t>::GetNewBufferBasedOnHandle() const {
+  String::FlatContent content = source_handle_->GetFlatContent();
+  return reinterpret_cast<const int8_t*>(content.ToOneByteVector().start());
+}
+
+}
+}