Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 881893002: Revert of Plumb allow_overlay flag for video path into cc (Closed)

Created:
5 years, 11 months ago by James Cook
Modified:
5 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org, vrk (LEFT CHROMIUM)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Plumb allow_overlay flag for video path into cc (patchset #3 id:80001 of https://codereview.chromium.org/806413004/) Reason for revert: This breaks the Chrome OS daisy (32-bit ARM) builder: http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/4364/steps/BuildPackages/logs/stdio It just looks like a missing callsite. Original issue's description: > Plumb allow_overlay flag for video path into cc > > This will allow hardware video overlays to be enabled in the compositor > > Committed: https://crrev.com/32c0609baa6c3eea2400c6fe899a0ff60a1358dd > Cr-Commit-Position: refs/heads/master@{#313310} TBR=jschuh@chromium.org,piman@chromium.org,alexst@chromium.org,dalecurtis@chromium.org,posciak@chromium.org,achaulk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/afc2e6020224ed985c327c9559c2392e2b62e618 Cr-Commit-Position: refs/heads/master@{#313345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -103 lines) Patch
M cc/resources/video_resource_updater.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +18 lines, -12 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +14 lines, -9 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M content/renderer/pepper/video_decoder_shim.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/video_frame.h View 3 chunks +1 line, -6 lines 0 comments Download
M media/base/video_frame.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M media/base/video_frame_unittest.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M media/video/picture.h View 2 chunks +1 line, -5 lines 0 comments Download
M media/video/picture.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Created Revert of Plumb allow_overlay flag for video path into cc
5 years, 11 months ago (2015-01-27 20:21:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881893002/1
5 years, 11 months ago (2015-01-27 20:22:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 20:24:04 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:26:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afc2e6020224ed985c327c9559c2392e2b62e618
Cr-Commit-Position: refs/heads/master@{#313345}

Powered by Google App Engine
This is Rietveld 408576698