media/filters/gpu_video_decoder.cc - Issue 881893002: Revert of Plumb allow_overlay flag for video path into cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 881893002: Revert of Plumb allow_overlay flag for video path into cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/gpu_video_decoder.cc

diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc

index fa4577a1178fc9ed1a30fd93c509798eef63d03d..6601db88ab377f1fbc999930d125e37f5bcdb36a 100644

--- a/media/filters/gpu_video_decoder.cc

+++ b/media/filters/gpu_video_decoder.cc

@@ -450,12 +450,16 @@

scoped_refptr<VideoFrame> frame(VideoFrame::WrapNativeTexture(

make_scoped_ptr(new gpu::MailboxHolder(

pb.texture_mailbox(), decoder_texture_target_, 0 /* sync_point */)),

- BindToCurrentLoop(base::Bind(

- &GpuVideoDecoder::ReleaseMailbox, weak_factory_.GetWeakPtr(),

- factories_, picture.picture_buffer_id(), pb.texture_id())),

- pb.size(), visible_rect, natural_size, timestamp,

- base::Bind(&ReadPixelsSync, factories_, pb.texture_id(), visible_rect),

- picture.allow_overlay()));

+ BindToCurrentLoop(base::Bind(&GpuVideoDecoder::ReleaseMailbox,

+ weak_factory_.GetWeakPtr(),

+ factories_,

+ picture.picture_buffer_id(),

+ pb.texture_id())),

+ pb.size(),

+ visible_rect,

+ natural_size,

+ timestamp,

+ base::Bind(&ReadPixelsSync, factories_, pb.texture_id(), visible_rect)));

CHECK_GT(available_pictures_, 0);

--available_pictures_;

bool inserted =

« no previous file with comments | « media/base/video_frame_unittest.cc ('k') | media/video/picture.h » ('j') | no next file with comments »