Roll Clang 223108:228742

Roll Clang 223108:228742

Also introduce a build number in the package name, stop versioning
the Blink GC plugin, and remove repackage.sh.

BUG=444089

[hans, 2015-02-05 23:47:56]

hans@chromium.org changed reviewers:
+ jbauman@chromium.org, jln@chromium.org, thakis@chromium.org

[hans, 2015-02-05 23:47:57]

jln: for sandbox/linux/OWNERS and content/zygote/OWNERS
jbauman: for content/gpu/OWNERS

[jbauman, 2015-02-05 23:50:26]

lgtm

[Nico, 2015-02-05 23:51:49]

lgtm, nice!

cc glider for sigbus change, zerny for deletion of repackage.sh

https://codereview.chromium.org/881763003/diff/60001/tools/clang/scripts/upda...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/881763003/diff/60001/tools/clang/scripts/upda...
tools/clang/scripts/update.sh:12: CLANG_BUILD=1
this could use a better name, and maybe a short comment

[jln (very slow on Chromium), 2015-02-05 23:54:14]

sandbox/ and content/zygote/ lgtm, thanks!

https://codereview.chromium.org/881763003/diff/60001/sandbox/linux/bpf_dsl/bp...
File sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc (right):

https://codereview.chromium.org/881763003/diff/60001/sandbox/linux/bpf_dsl/bp...
sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc:687: #endif
 Add // !defined(ADDRESS_SANITIZER)

[hans, 2015-02-06 00:05:25]

New patchsets have been uploaded after l-g-t-m from
jbauman@chromium.org,thakis@chromium.org,jln@chromium.org

[hans, 2015-02-06 00:05:34]

https://codereview.chromium.org/881763003/diff/60001/sandbox/linux/bpf_dsl/bp...
File sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc (right):

https://codereview.chromium.org/881763003/diff/60001/sandbox/linux/bpf_dsl/bp...
sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc:687: #endif
On 2015/02/05 23:54:14, jln wrote:
>  Add // !defined(ADDRESS_SANITIZER)

Done.

https://codereview.chromium.org/881763003/diff/60001/tools/clang/scripts/upda...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/881763003/diff/60001/tools/clang/scripts/upda...
tools/clang/scripts/update.sh:12: CLANG_BUILD=1
On 2015/02/05 23:51:49, Nico wrote:
> this could use a better name, and maybe a short comment

Done. I've renamed it CLANG_SUB_REVISION and added a comment.

[pcc, 2015-02-06 00:05:55]

Could we perhaps roll a little further to r228196, which fixes a bug I
encountered that presumably only manifests under LTO.

[hans, 2015-02-06 00:06:01]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2015-02-06 00:06:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/881763003/80001

[Nico, 2015-02-06 00:07:05]

On 2015/02/06 00:05:55, pcc wrote:
> Could we perhaps roll a little further to r228196, which fixes a bug I
> encountered that presumably only manifests under LTO.

i think lto is experimental enough that we shouldn't do anything for it yet.
you'll need other changes too for sure :-) rolling is hard enough as is etc.

[hans, 2015-02-06 00:08:47]

On 2015/02/06 00:05:55, pcc wrote:
> Could we perhaps roll a little further to r228196, which fixes a bug I
> encountered that presumably only manifests under LTO.

This roll is going too good for me to start over :)

If this one fails we might need to roll further, otherwise it will be in the
next roll (which should hopefully happen soon than this one did).

[commit-bot: I haz the power, 2015-02-06 02:11:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-06 02:13:14]

Patchset 5 (id:??) landed as
https://crrev.com/d30327adf468b78f79819a69bca12b64b7cb70ae
Cr-Commit-Position: refs/heads/master@{#314946}

[tapted, 2015-02-06 02:41:00]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/898713004/ by tapted@chromium.org.

The reason for reverting is: compiler crash in
http://build.chromium.org/p/chromium/builders/Mac/builds/33226

Assertion failed: (Offset <= PieceOffset && "overlapping or duplicate pieces"),
function emitLocPieces, file
/work/chromium/src/third_party/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp, line
1676.

0.	Program arguments:
/Volumes/data/b/build/slave/Mac/build/src/third_party/llvm-build/Release+Asserts/bin/clang
-cc1 -triple x86_64-apple-macosx10.6.0 /* snip */ -x c
../../third_party/mesa/src/src/mesa/program/prog_opt_constant_fold.c 
1.	<eof> parser at end of file
2.	Code generation
clang:error: unable to execute command: Illegal instruction: 4
clang:error: clang frontend command failed due to signal (use -v to see
invocation)
clang version 3.7.0 (trunk 228129)
Target: x86_64-apple-darwin13.4.0.

[hans, 2015-02-11 04:30:57]

hans@chromium.org changed reviewers:
- jbauman@chromium.org, jln@chromium.org