Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(190)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: tools/clang/plugins/tests/weak_ptr_factory.flags
Issue
881763003
:
Roll Clang 223108:228742 (Closed)
Base URL: precise:/work/chromium/src@clang_roll_226907
Patch Set: Re-upload
Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
content/gpu/gpu_main.cc
content/zygote/zygote_main_linux.cc
sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc
tools/clang/blink_gc_plugin/CMakeLists.txt
tools/clang/blink_gc_plugin/Edge.h
tools/clang/blink_gc_plugin/RecordInfo.h
tools/clang/blink_gc_plugin/tests/test.sh
tools/clang/plugins/tests/weak_ptr_factory.flags
tools/clang/scripts/blink_gc_plugin_flags.sh
tools/clang/scripts/package.sh
tools/clang/scripts/plugin_flags.sh
tools/clang/scripts/repackage.sh
tools/clang/scripts/update.sh
View unified diff
|
Download patch
« no previous file with comments
|
« tools/clang/blink_gc_plugin/tests/test.sh
('k') |
tools/clang/scripts/blink_gc_plugin_flags.sh »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates
-Xclang -plugin-
arg-find-bad-constructs -Xclang check-weak-ptr-factory-order
1
-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates
OLD
NEW
« no previous file with comments
|
« tools/clang/blink_gc_plugin/tests/test.sh
('k') |
tools/clang/scripts/blink_gc_plugin_flags.sh »
('j') |
no next file with comments »
Issue 881763003: Roll Clang 223108:228742 (Closed)
Created 5 years, 10 months ago by hans
Modified 5 years, 2 months ago
Reviewers: Nico
Base URL: precise:/work/chromium/src@clang_roll_226907
Comments: 4
This is Rietveld
408576698