Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 881683002: Remove indirection for SiteInstance and RenderProcessHost from RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index c9193a3080131997b6b1f299a898d078efba9ae2..8eddca6bbeaa3d99d39f8f40b645c113daac146e 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -535,6 +535,17 @@ class CONTENT_EXPORT RenderFrameHostImpl
RenderFrameHostDelegate* delegate_;
+ // The SiteInstance associated with this RenderFrameHost. All content drawn
+ // in this RenderFrameHost is part of this SiteInstance. Cannot change over
+ // time.
+ scoped_refptr<SiteInstanceImpl> site_instance_;
+
+ // The renderer process this RenderFrameHost is associated with. It is
+ // equivalent to the result of site_instance_->GetProcess(), but that
+ // method has the side effect of creating the process if it doesn't exist.
+ // Use a raw pointer to avoid unnecessary process creation.
Charlie Reis 2015/01/27 02:09:04 Use a raw pointer -> Cache a pointer
nasko 2015/01/27 22:30:34 Done.
+ RenderProcessHost* process_;
+
// |cross_process_frame_connector_| passes messages from an out-of-process
// child frame to the parent process for compositing.
//

Powered by Google App Engine
This is Rietveld 408576698