Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 881683002: Remove indirection for SiteInstance and RenderProcessHost from RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
528 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a 528 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
529 // refcount that calls Shutdown when it reaches zero. This allows each 529 // refcount that calls Shutdown when it reaches zero. This allows each
530 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring 530 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
531 // we have a RenderViewHost for each RenderFrameHost. 531 // we have a RenderViewHost for each RenderFrameHost.
532 // TODO(creis): RenderViewHost will eventually go away and be replaced with 532 // TODO(creis): RenderViewHost will eventually go away and be replaced with
533 // some form of page context. 533 // some form of page context.
534 RenderViewHostImpl* render_view_host_; 534 RenderViewHostImpl* render_view_host_;
535 535
536 RenderFrameHostDelegate* delegate_; 536 RenderFrameHostDelegate* delegate_;
537 537
538 // The SiteInstance associated with this RenderFrameHost. All content drawn
539 // in this RenderFrameHost is part of this SiteInstance. Cannot change over
540 // time.
541 scoped_refptr<SiteInstanceImpl> site_instance_;
542
543 // The renderer process this RenderFrameHost is associated with. It is
544 // equivalent to the result of site_instance_->GetProcess(), but that
545 // method has the side effect of creating the process if it doesn't exist.
546 // Use a raw pointer to avoid unnecessary process creation.
Charlie Reis 2015/01/27 02:09:04 Use a raw pointer -> Cache a pointer
nasko 2015/01/27 22:30:34 Done.
547 RenderProcessHost* process_;
548
538 // |cross_process_frame_connector_| passes messages from an out-of-process 549 // |cross_process_frame_connector_| passes messages from an out-of-process
539 // child frame to the parent process for compositing. 550 // child frame to the parent process for compositing.
540 // 551 //
541 // This is only non-NULL when this is the swapped out RenderFrameHost in 552 // This is only non-NULL when this is the swapped out RenderFrameHost in
542 // the same site instance as this frame's parent. 553 // the same site instance as this frame's parent.
543 // 554 //
544 // See the class comment above CrossProcessFrameConnector for more 555 // See the class comment above CrossProcessFrameConnector for more
545 // information. 556 // information.
546 // 557 //
547 // This will move to RenderFrameProxyHost when that class is created. 558 // This will move to RenderFrameProxyHost when that class is created.
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 665
655 // NOTE: This must be the last member. 666 // NOTE: This must be the last member.
656 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 667 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
657 668
658 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 669 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
659 }; 670 };
660 671
661 } // namespace content 672 } // namespace content
662 673
663 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 674 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698