Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 881433002: Use a WeakCell in the CallIC type vector. (Closed)

Created:
5 years, 11 months ago by mvstanton
Modified:
5 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use a WeakCell in the CallIC type vector. This allows us to clear the IC on a more sedate schedule, just like Load and Store ICs. R=ulan@chromium.org BUG= Committed: https://crrev.com/bcc79d33ca6d97d9ecfcfcf110a6ea84a0225389 Cr-Commit-Position: refs/heads/master@{#26332}

Patch Set 1 #

Patch Set 2 : Ports. #

Patch Set 3 : Bugfix in type-info, and test fixes. #

Patch Set 4 : Now with fix for Mandreel Regression. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -81 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 3 chunks +33 lines, -9 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 3 1 chunk +13 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 3 chunks +32 lines, -14 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 3 1 chunk +17 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 2 chunks +34 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 chunks +33 lines, -11 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 3 1 chunk +13 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M src/type-feedback-vector.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/type-info.cc View 1 2 1 chunk +12 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 chunks +36 lines, -11 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 3 1 chunk +13 lines, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 2 2 chunks +18 lines, -18 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
mvstanton
Hi Ulan, Here is the weak cell handling for CallICs. Thanks for the look! --Michael
5 years, 10 months ago (2015-01-28 13:11:22 UTC) #2
ulan
LGTM!
5 years, 10 months ago (2015-01-28 13:35:41 UTC) #3
mvstanton
Thanks for the look at this Ulan. As you see, I had to repair a ...
5 years, 10 months ago (2015-01-29 16:16:25 UTC) #4
ulan
On 2015/01/29 16:16:25, mvstanton wrote: > Thanks for the look at this Ulan. > As ...
5 years, 10 months ago (2015-01-29 16:36:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881433002/80001
5 years, 10 months ago (2015-01-29 16:52:52 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-01-29 17:36:37 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/bcc79d33ca6d97d9ecfcfcf110a6ea84a0225389 Cr-Commit-Position: refs/heads/master@{#26332}
5 years, 10 months ago (2015-01-29 17:37:00 UTC) #9
Michael Achenbach
5 years, 10 months ago (2015-01-29 18:00:01 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/886663004/ by machenbach@chromium.org.

The reason for reverting is: Breaks a regression test on linux isloates, and
linux with gcc 4.8..

Powered by Google App Engine
This is Rietveld 408576698