src/ic/ic.cc - Issue 881433002: Use a WeakCell in the CallIC type vector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 881433002: Use a WeakCell in the CallIC type vector. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Now with fix for Mandreel Regression. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index e6b691b9265664a4c28956cdf65481390e465779..063a695d1c4e17499b815563ef3a45c7c58b4711 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -2217,7 +2217,7 @@ void CallIC::HandleMiss(Handle<Object> receiver, Handle<Object> function) {

// Hand-coded MISS handling is easier if CallIC slots don't contain smis.

DCHECK(!feedback->IsSmi());

- if (feedback->IsJSFunction() || !function->IsJSFunction()) {

+ if (feedback->IsWeakCell() || !function->IsJSFunction()) {

// We are going generic.

nexus->ConfigureGeneric();

} else {

« no previous file with comments | « src/ia32/interface-descriptors-ia32.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »