Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 881423002: Fixed clusterfuzz issue (Closed)

Created:
5 years, 10 months ago by sugoi1
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/core/SkBitmap.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sugoi1
Not sure this is the best fix, but at least I'm fairly certain it's safe ...
5 years, 10 months ago (2015-01-28 20:51:53 UTC) #2
reed1
The null-check is very correct, as NewWithData can return for a variety of reasons. lgtm
5 years, 10 months ago (2015-01-28 21:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881423002/1
5 years, 10 months ago (2015-01-28 21:09:29 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 21:15:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6af314724f51ad79a640844536c667bb83de5690

Powered by Google App Engine
This is Rietveld 408576698