Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 881363004: Remove extra call to UsbDeviceHandle::Close in chrome.usb.closeDevice. (Closed)

Created:
5 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove extra call to UsbDeviceHandle::Close in chrome.usb.closeDevice. When chrome.usb.closeDevice is called the device is explicitly closed in the extension function implementation and then closed again when the UsbDeviceResource object is destroyed. Only the latter is necessary as that covers other ways in which the resource can be released. Committed: https://crrev.com/db9f276136d0eb947bcc31d1de6d0535400fb741 Cr-Commit-Position: refs/heads/master@{#313605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M extensions/browser/api/usb/usb_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Marijn, can you take a look at this patch?
5 years, 10 months ago (2015-01-28 21:43:35 UTC) #2
Marijn Kruisselbrink
LGTM Maybe remove the BUG= line in the description, or change it to something like ...
5 years, 10 months ago (2015-01-28 21:56:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881363004/1
5 years, 10 months ago (2015-01-28 21:58:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 23:10:45 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 23:12:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db9f276136d0eb947bcc31d1de6d0535400fb741
Cr-Commit-Position: refs/heads/master@{#313605}

Powered by Google App Engine
This is Rietveld 408576698