extensions/browser/api/usb/usb_api.cc - Issue 881363004: Remove extra call to UsbDeviceHandle::Close in chrome.usb.closeDevice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/usb/usb_api.cc

Issue 881363004: Remove extra call to UsbDeviceHandle::Close in chrome.usb.closeDevice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/usb/usb_api.cc

diff --git a/extensions/browser/api/usb/usb_api.cc b/extensions/browser/api/usb/usb_api.cc

index 44d6f4cd3be6df5bd7078e6a89c2c3526417f417..329287cd2f73536017b478553cc67e8b830a89fc 100644

--- a/extensions/browser/api/usb/usb_api.cc

+++ b/extensions/browser/api/usb/usb_api.cc

@@ -940,7 +940,7 @@ void UsbCloseDeviceFunction::AsyncWorkStart() {

if (!device_handle.get())

return;

- device_handle->Close();

+ // The device handle is closed when the resource is destroyed.

RemoveUsbDeviceResource(parameters_->handle.handle);

AsyncWorkCompleted();

}

« no previous file with comments | « no previous file | extensions/browser/api/usb/usb_apitest.cc » ('j') | no next file with comments »