offset namespace ids

[DOMStorage] (recommitting) Offset the session storage namespace ids generated by different contexts to help identify when an id from one is mistakenly used in another.

>> Committed: https://crrev.com/36dcef3da5317365ab95e50a5f6b7fa98ada1d5e
>> Cr-Commit-Position: refs/heads/master@{#314256}
>
> Reverted: https://crrev.com/7bdc4a49e605261b60ee1339f93e835d853bf645
> Cr-Commit-Position: refs/heads/master@{#314274}

Committed: https://crrev.com/8da7297aa9142a0ad21f730e0b3b325dbf585683
Cr-Commit-Position: refs/heads/master@{#314713}

[michaeln, 2015-01-29 01:22:56]

michaeln@chromium.org changed reviewers:
+ jsbell@chromium.org

[michaeln, 2015-01-29 01:23:07]

ptal

[jsbell, 2015-01-30 18:10:16]

lgtm; can you tweak the CL subject line to mention DOM Storage?

https://codereview.chromium.org/881253004/diff/80001/content/browser/dom_stor...
File content/browser/dom_storage/dom_storage_context_impl.cc (right):

https://codereview.chromium.org/881253004/diff/80001/content/browser/dom_stor...
content/browser/dom_storage/dom_storage_context_impl.cc:30: static int
g_session_id_offset_sequence;
explicitly initialize to 0?

(just for readability; it's done implicitly)

Also, can you comment here why this is used? (i.e. same as the CL description)

[michaeln, 2015-02-02 21:41:28]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2015-02-02 21:41:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/881253004/120001

[commit-bot: I haz the power, 2015-02-03 03:12:23]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-02-03 03:13:40]

Patchset 7 (id:??) landed as
https://crrev.com/36dcef3da5317365ab95e50a5f6b7fa98ada1d5e
Cr-Commit-Position: refs/heads/master@{#314256}

[Lei Zhang, 2015-02-03 05:40:13]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/896733002/ by thestig@chromium.org.

The reason for reverting is: Tests now only work if they ran in the "right"
order. DOMStorageContextImplTest.Basic fails if the tests are shuffled:

content_unittests
--gtest_filter=DOMStorageContextImplTest.*:DOMStorageAreaTest.* --gtest_shuffle.

[michaeln, 2015-02-03 18:45:50]

gah!

[michaeln, 2015-02-05 00:04:58]

recommitting with the tests fixed

[michaeln, 2015-02-05 00:05:07]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2015-02-05 00:06:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/881253004/180001

[commit-bot: I haz the power, 2015-02-05 01:46:47]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-02-05 01:47:50]

Patchset 10 (id:??) landed as
https://crrev.com/8da7297aa9142a0ad21f730e0b3b325dbf585683
Cr-Commit-Position: refs/heads/master@{#314713}