Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: content/browser/dom_storage/dom_storage_context_impl.h

Issue 881253004: offset namespace ids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/dom_storage/dom_storage_context_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/dom_storage/dom_storage_context_impl.h
diff --git a/content/browser/dom_storage/dom_storage_context_impl.h b/content/browser/dom_storage/dom_storage_context_impl.h
index 4470df569ecff6d73dde2473b4b5da98172356e0..de848dd5de8b1eb666ba18bee72bad27cbd08079 100644
--- a/content/browser/dom_storage/dom_storage_context_impl.h
+++ b/content/browser/dom_storage/dom_storage_context_impl.h
@@ -147,10 +147,7 @@ class CONTENT_EXPORT DOMStorageContextImpl
const GURL& page_url);
// May be called on any thread.
- int64 AllocateSessionId() {
- return session_id_sequence_.GetNext();
- }
-
+ int64 AllocateSessionId();
std::string AllocatePersistentSessionId();
// Must be called on the background thread.
@@ -207,7 +204,10 @@ class CONTENT_EXPORT DOMStorageContextImpl
// We use a 32 bit identifier for per tab storage sessions.
// At a tab per second, this range is large enough for 68 years.
+ // The offset is to more quickly detect the error condition where
+ // an id related to one context is mistakenly used in another.
base::AtomicSequenceNumber session_id_sequence_;
+ const int session_id_offset_;
bool is_shutdown_;
bool force_keep_session_state_;
« no previous file with comments | « no previous file | content/browser/dom_storage/dom_storage_context_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698