Issue 880963002: Add missing FrameState to JSToName nodes.

Issue 880963002: Add missing FrameState to JSToName nodes. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger

Modified:
5 years, 10 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Add missing FrameState to JSToName nodes. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-451770 BUG=chromium:451770 LOG=N Committed: https://crrev.com/c5833e8596a40c88f3528791c14643156b73e350 Cr-Commit-Position: refs/heads/master@{#26305}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -26 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm64/full-codegen-arm64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ast.h	View		2 chunks	+13 lines, -2 lines	0 comments	Download
M	src/ast-numbering.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/ast-graph-builder.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/ast-graph-builder.cc	View		3 chunks	+8 lines, -4 lines	0 comments	Download
M	src/compiler/operator-properties.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/full-codegen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/full-codegen.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips64/full-codegen-mips64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x87/full-codegen-x87.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-451770.js	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/js-operator-unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

Michael Starzinger

Note that architecture ports are still missing.

5 years, 11 months ago (2015-01-27 15:56:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880963002/20001

5 years, 10 months ago (2015-01-28 11:38:09 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-01-28 11:40:11 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/c5833e8596a40c88f3528791c14643156b73e350
Cr-Commit-Position: refs/heads/master@{#26305}