Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 880963002: Add missing FrameState to JSToName nodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ported to other architectures. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1792 matching lines...) Expand 10 before | Expand all | Expand 10 after
1803 1803
1804 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) { 1804 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) {
1805 DCHECK(!property->is_computed_name()); 1805 DCHECK(!property->is_computed_name());
1806 VisitForStackValue(value); 1806 VisitForStackValue(value);
1807 if (property->emit_store()) { 1807 if (property->emit_store()) {
1808 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1808 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1809 } else { 1809 } else {
1810 __ Drop(2); 1810 __ Drop(2);
1811 } 1811 }
1812 } else { 1812 } else {
1813 EmitPropertyKey(property); 1813 EmitPropertyKey(property, expr->GetIdForProperty(property_index));
1814 VisitForStackValue(value); 1814 VisitForStackValue(value);
1815 1815
1816 switch (property->kind()) { 1816 switch (property->kind()) {
1817 case ObjectLiteral::Property::CONSTANT: 1817 case ObjectLiteral::Property::CONSTANT:
1818 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1818 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1819 case ObjectLiteral::Property::COMPUTED: 1819 case ObjectLiteral::Property::COMPUTED:
1820 if (property->emit_store()) { 1820 if (property->emit_store()) {
1821 __ mov(r0, Operand(Smi::FromInt(NONE))); 1821 __ mov(r0, Operand(Smi::FromInt(NONE)));
1822 __ push(r0); 1822 __ push(r0);
1823 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4); 1823 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4);
(...skipping 719 matching lines...) Expand 10 before | Expand all | Expand 10 after
2543 for (int i = 0; i < lit->properties()->length(); i++) { 2543 for (int i = 0; i < lit->properties()->length(); i++) {
2544 ObjectLiteral::Property* property = lit->properties()->at(i); 2544 ObjectLiteral::Property* property = lit->properties()->at(i);
2545 Expression* value = property->value(); 2545 Expression* value = property->value();
2546 2546
2547 if (property->is_static()) { 2547 if (property->is_static()) {
2548 __ ldr(scratch, MemOperand(sp, kPointerSize)); // constructor 2548 __ ldr(scratch, MemOperand(sp, kPointerSize)); // constructor
2549 } else { 2549 } else {
2550 __ ldr(scratch, MemOperand(sp, 0)); // prototype 2550 __ ldr(scratch, MemOperand(sp, 0)); // prototype
2551 } 2551 }
2552 __ push(scratch); 2552 __ push(scratch);
2553 EmitPropertyKey(property); 2553 EmitPropertyKey(property, lit->GetIdForProperty(i));
2554 VisitForStackValue(value); 2554 VisitForStackValue(value);
2555 EmitSetHomeObjectIfNeeded(value, 2); 2555 EmitSetHomeObjectIfNeeded(value, 2);
2556 2556
2557 switch (property->kind()) { 2557 switch (property->kind()) {
2558 case ObjectLiteral::Property::CONSTANT: 2558 case ObjectLiteral::Property::CONSTANT:
2559 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2559 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2560 case ObjectLiteral::Property::COMPUTED: 2560 case ObjectLiteral::Property::COMPUTED:
2561 case ObjectLiteral::Property::PROTOTYPE: 2561 case ObjectLiteral::Property::PROTOTYPE:
2562 __ CallRuntime(Runtime::kDefineClassMethod, 3); 2562 __ CallRuntime(Runtime::kDefineClassMethod, 3);
2563 break; 2563 break;
(...skipping 2847 matching lines...) Expand 10 before | Expand all | Expand 10 after
5411 5411
5412 DCHECK(interrupt_address == 5412 DCHECK(interrupt_address ==
5413 isolate->builtins()->OsrAfterStackCheck()->entry()); 5413 isolate->builtins()->OsrAfterStackCheck()->entry());
5414 return OSR_AFTER_STACK_CHECK; 5414 return OSR_AFTER_STACK_CHECK;
5415 } 5415 }
5416 5416
5417 5417
5418 } } // namespace v8::internal 5418 } } // namespace v8::internal
5419 5419
5420 #endif // V8_TARGET_ARCH_ARM 5420 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698