Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880873003: Add unit tests target to GN build. (Closed)

Created:
5 years, 11 months ago by brettw
Modified:
5 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, dcheng, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit tests target to GN build. Minor related GYP cleanup and added some missing dependencies and related targets to the GN build. Support for compiling unit_tests with no ENABLE_WEBRTC. Remove browser_action_drag_data_unittest.cc which is not compiled on any currently supported platform. BUG= Committed: https://crrev.com/a68ea2b7bba60fe9dcda30d2ad0a8fe7fb65d3ba Cr-Commit-Position: refs/heads/master@{#314078}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : more #

Patch Set 5 : git cl try #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : chromeos #

Patch Set 9 : fix for Windows #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -93 lines) Patch
M build/json_schema_api.gni View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 22 chunks +20 lines, -33 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 4 chunks +516 lines, -0 lines 0 comments Download
A chrome/tools/convert_dict/BUILD.gn View 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/tools/convert_dict/convert_dict.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/tools/profile_reset/BUILD.gn View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/tools/profile_reset/jtl_compiler.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A tools/json_schema_compiler/test/BUILD.gn View 1 chunk +47 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/test/json_schema_compiler_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
brettw
5 years, 11 months ago (2015-01-27 21:58:14 UTC) #2
Dirk Pranke
lgtm w/ one question ... https://codereview.chromium.org/880873003/diff/20001/chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc File chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc (left): https://codereview.chromium.org/880873003/diff/20001/chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc#oldcode1 chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc:1: // Copyright (c) 2012 ...
5 years, 11 months ago (2015-01-27 22:37:29 UTC) #3
brettw
https://codereview.chromium.org/880873003/diff/20001/chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc File chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc (left): https://codereview.chromium.org/880873003/diff/20001/chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc#oldcode1 chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
5 years, 11 months ago (2015-01-27 23:33:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880873003/120002
5 years, 10 months ago (2015-01-31 01:43:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880873003/160001
5 years, 10 months ago (2015-02-01 01:13:45 UTC) #8
commit-bot: I haz the power
Committed patchset #10 (id:160001)
5 years, 10 months ago (2015-02-01 02:54:34 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-01 02:55:31 UTC) #10
Message was sent while issue was closed. 
Patchset 10 (id:??) landed as
https://crrev.com/a68ea2b7bba60fe9dcda30d2ad0a8fe7fb65d3ba
Cr-Commit-Position: refs/heads/master@{#314078}

Powered by Google App Engine
This is Rietveld 408576698