Add unit tests target to GN build.

chrome/chrome_tests_unit.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'variables': {
     'chrome_unit_tests_sources': [
       '../components/autofill/content/renderer/test_password_autofill_agent.cc',
       '../components/autofill/content/renderer/test_password_autofill_agent.h',
       '../components/autofill/content/renderer/test_password_generation_agent.cc',
       '../components/autofill/content/renderer/test_password_generation_agent.h',
       # histograms.xml is analyzed by AboutFlagsHistogramTest, so this
       # dependency is needed to make commit bots run unit_tests on
       # histograms.xml changes.
       '../tools/metrics/histograms/histograms.xml',
-      'app/chrome_dll.rc',
       # All unittests in browser, common, renderer and service.
       'browser/about_flags_unittest.cc',
       'browser/android/bookmarks/partner_bookmarks_shim_unittest.cc',
       # TODO(newt): move this to test_support_unit?
       'browser/android/mock_location_settings.cc',
       'browser/android/mock_location_settings.h',
       'browser/android/preferences/pref_service_bridge_unittest.cc',
       'browser/android/thumbnail/scoped_ptr_expiring_cache_unittest.cc',
       'browser/android/shortcut_helper_unittest.cc',
       'browser/app_controller_mac_unittest.mm',
@@ skipping 125 matching lines @@
       'browser/net/connection_tester_unittest.cc',
       'browser/net/dns_probe_runner_unittest.cc',
       'browser/net/dns_probe_service_unittest.cc',
       'browser/net/evicted_domain_cookie_counter_unittest.cc',
       'browser/net/net_error_tab_helper_unittest.cc',
       'browser/net/net_log_temp_file_unittest.cc',
       'browser/net/network_stats_unittest.cc',
       'browser/net/predictor_unittest.cc',
       'browser/net/pref_proxy_config_tracker_impl_unittest.cc',
       'browser/net/probe_message_unittest.cc',
-      'browser/net/proxy_policy_handler_unittest.cc',
       'browser/net/quota_policy_channel_id_store_unittest.cc',
       'browser/net/safe_search_util_unittest.cc',
       'browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc',
       'browser/net/ssl_config_service_manager_pref_unittest.cc',
       'browser/net/url_info_unittest.cc',
       'browser/password_manager/chrome_password_manager_client_unittest.cc',
       'browser/password_manager/password_manager_internals_service_unittest.cc',
       'browser/password_manager/password_manager_metrics_util_unittest.cc',
       'browser/password_manager/password_store_mac_unittest.cc',
       'browser/password_manager/password_store_win_unittest.cc',
       'browser/password_manager/password_store_x_unittest.cc',
       'browser/predictors/autocomplete_action_predictor_table_unittest.cc',
       'browser/predictors/autocomplete_action_predictor_unittest.cc',
       'browser/predictors/resource_prefetch_common_unittest.cc',
       'browser/predictors/resource_prefetch_predictor_unittest.cc',
       'browser/predictors/resource_prefetch_predictor_tables_unittest.cc',
       'browser/predictors/resource_prefetcher_unittest.cc',
       'browser/prefs/chrome_pref_service_unittest.cc',
       'browser/prefs/command_line_pref_store_unittest.cc',
       'browser/prefs/incognito_mode_prefs_unittest.cc',
       'browser/prefs/leveldb_pref_store_unittest.cc',
       'browser/prefs/pref_model_associator_unittest.cc',
       'browser/prefs/prefs_syncable_service_unittest.cc',
       'browser/prefs/profile_pref_store_manager_unittest.cc',
       'browser/prefs/proxy_config_dictionary_unittest.cc',
-      'browser/prefs/proxy_policy_unittest.cc',
       'browser/prefs/proxy_prefs_unittest.cc',
       'browser/prefs/session_startup_pref_unittest.cc',
       'browser/prefs/tracked/mock_validation_delegate.cc',
       'browser/prefs/tracked/mock_validation_delegate.h',
       'browser/prefs/tracked/pref_hash_calculator_unittest.cc',
       'browser/prefs/tracked/pref_hash_filter_unittest.cc',
       'browser/prefs/tracked/pref_hash_store_impl_unittest.cc',
       'browser/prefs/tracked/pref_service_hash_store_contents_unittest.cc',
       'browser/prefs/tracked/segregated_pref_store_unittest.cc',
       'browser/prefs/tracked/tracked_preferences_migration_unittest.cc',
       'browser/prerender/prerender_history_unittest.cc',
       'browser/prerender/prerender_tracker_unittest.cc',
       'browser/prerender/prerender_unittest.cc',
       'browser/prerender/prerender_util_unittest.cc',
       'browser/process_info_snapshot_mac_unittest.cc',
       'browser/profiles/file_path_verifier_win_unittest.cc',
       'browser/profiles/gaia_info_update_service_unittest.cc',
-      'browser/profiles/incognito_mode_policy_handler_unittest.cc',
       'browser/profiles/profile_downloader_unittest.cc',
       'browser/profiles/profile_info_cache_unittest.cc',
       'browser/profiles/profile_info_cache_unittest.h',
       'browser/profiles/profile_avatar_icon_util_unittest.cc',
       'browser/profiles/profile_manager_unittest.cc',
       'browser/profiles/profile_shortcut_manager_unittest_win.cc',
       'browser/renderer_context_menu/render_view_context_menu_test_util.cc',
       'browser/renderer_context_menu/render_view_context_menu_test_util.h',
       'browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm',
       'browser/resources/google_now/background.js',
@@ skipping 12 matching lines @@
       'browser/resources_util_unittest.cc',
       'browser/rlz/rlz_unittest.cc',
       'browser/search/contextual_search_policy_handler_android_unittest.cc',
       'browser/search/iframe_source_unittest.cc',
       'browser/search/instant_unittest_base.cc',
       'browser/search/instant_unittest_base.h',
       'browser/search/most_visited_iframe_source_unittest.cc',
       'browser/search/search_android_unittest.cc',
       'browser/search_engines/default_search_pref_migration_unittest.cc',
       'browser/search_engines/search_provider_install_data_unittest.cc',
-      'browser/search_engines/template_url_scraper_unittest.cc',
       'browser/service_process/service_process_control_mac_unittest.mm',
       'browser/services/gcm/fake_gcm_profile_service.cc',
       'browser/services/gcm/fake_gcm_profile_service.h',
       'browser/services/gcm/fake_signin_manager.cc',
       'browser/services/gcm/fake_signin_manager.h',
       'browser/services/gcm/gcm_account_tracker_unittest.cc',
       'browser/services/gcm/push_messaging_application_id_unittest.cc',
       'browser/services/gcm/push_messaging_permission_context_unittest.cc',
-      'browser/sessions/restore_on_startup_policy_handler_unittest.cc',
       'browser/shell_integration_win_unittest.cc',
       'browser/signin/account_reconcilor_unittest.cc',
       'browser/signin/account_service_flag_fetcher_unittest.cc',
       'browser/signin/local_auth_unittest.cc',
       'browser/signin/signin_global_error_unittest.cc',
       'browser/signin/signin_manager_unittest.cc',
       'browser/signin/signin_names_io_thread_unittest.cc',
       'browser/signin/signin_tracker_unittest.cc',
       'browser/signin/test_signin_client_builder.cc',
       'browser/ssl/ssl_error_classification_unittest.cc',
@@ skipping 31 matching lines @@
       'browser/sync/profile_sync_service_autofill_unittest.cc',
       'browser/sync/profile_sync_service_bookmark_unittest.cc',
       'browser/sync/profile_sync_service_startup_unittest.cc',
       'browser/sync/profile_sync_service_typed_url_unittest.cc',
       'browser/sync/profile_sync_service_unittest.cc',
       'browser/sync/profile_sync_test_util.cc',
       'browser/sync/profile_sync_test_util.h',
       'browser/sync/sessions/session_data_type_controller_unittest.cc',
       'browser/sync/sessions/tab_node_pool_unittest.cc',
       'browser/sync/startup_controller_unittest.cc',
-      'browser/sync/sync_policy_handler_unittest.cc',
       'browser/sync/sync_startup_tracker_unittest.cc',
       'browser/sync/test/test_http_bridge_factory.cc',
       'browser/sync/test/test_http_bridge_factory.h',
       'browser/sync/test_profile_sync_service.cc',
       'browser/sync/test_profile_sync_service.h',
       'browser/task_profiler/task_profiler_data_serializer_unittest.cc',
       'browser/thumbnails/content_analysis_unittest.cc',
       'browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc',
       'browser/thumbnails/simple_thumbnail_crop_unittest.cc',
       'browser/thumbnails/thumbnail_service_unittest.cc',
@@ skipping 254 matching lines @@
       'renderer/searchbox/search_bouncer_unittest.cc',
       'renderer/searchbox/searchbox_extension_unittest.cc',
       'renderer/searchbox/searchbox_unittest.cc',
       'renderer/web_apps_unittest.cc',
       'test/base/chrome_render_view_test.cc',
       'test/base/chrome_render_view_test.h',
       'test/base/menu_model_test.cc',
       'test/base/menu_model_test.h',
       'test/base/v8_unit_test.cc',
       'test/base/v8_unit_test.h',
-      'test/data/resource.rc',
       'test/data/unit/framework_unittest.gtestjs',
       'test/logging/win/mof_data_parser_unittest.cc',
       'utility/chrome_content_utility_client_unittest.cc',
       'utility/cloud_print/pwg_encoder_unittest.cc',
 
       # Duplicate these tests here because PathService has more items in
       # unit_tests than in base_unittests.
       '../base/path_service_unittest.cc',
 
       '../components/search_engines/template_url_fetcher_unittest.cc',
@@ skipping 735 matching lines @@
       'browser/ui/views/autofill/autofill_dialog_views_unittest.cc',
       'browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc',
       'browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc',
       'browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc',
       'browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc',
       'browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc',
       'browser/ui/views/bookmarks/bookmark_sync_promo_view_unittest.cc',
       'browser/ui/views/confirm_bubble_views_unittest.cc',
       'browser/ui/views/crypto_module_password_dialog_view_unittest.cc',
       'browser/ui/views/desktop_media_picker_views_unittest.cc',
-      'browser/ui/views/extensions/browser_action_drag_data_unittest.cc',
       'browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc',
       'browser/ui/views/first_run_bubble_unittest.cc',
       'browser/ui/views/frame/browser_view_layout_unittest.cc',
       'browser/ui/views/frame/browser_view_unittest.cc',
       'browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc',
       'browser/ui/views/frame/test_with_browser_view.cc',
       'browser/ui/views/frame/test_with_browser_view.h',
       'browser/ui/views/frame/web_contents_close_handler_unittest.cc',
       'browser/ui/views/status_icons/status_tray_win_unittest.cc',
       'browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views_unittest.cc',
       'browser/ui/views/tabs/fake_base_tab_strip_controller.cc',
       'browser/ui/views/tabs/fake_base_tab_strip_controller.h',
       'browser/ui/views/tabs/stacked_tab_strip_layout_unittest.cc',
       'browser/ui/views/tabs/tab_strip_unittest.cc',
       'browser/ui/views/tabs/tab_unittest.cc',
       'browser/ui/views/toolbar/reload_button_unittest.cc',
       'browser/ui/views/toolbar/test_toolbar_actions_bar_helper_views.cc',
       'browser/ui/views/translate/translate_bubble_view_unittest.cc',
       'browser/ui/views/validation_message_bubble_delegate_unittest.cc',
     ],
+    'chrome_unit_tests_win_sources': [
+      'app/chrome_dll.rc',
+      'browser/search_engines/template_url_scraper_unittest.cc',
+      'test/data/resource.rc',
+    ],
     'chrome_unit_tests_mac_sources': [
       'browser/media_galleries/fileapi/iphoto_file_util_unittest.cc',
       'utility/media_galleries/iphoto_library_parser_unittest.cc',
     ],
     'chrome_unit_tests_win_mac_sources': [
       'browser/media_galleries/fileapi/itunes_file_util_unittest.cc',
       'browser/media_galleries/fileapi/picasa_file_util_unittest.cc',
       'common/extensions/api/networking_private/networking_private_crypto_unittest.cc',
       'utility/media_galleries/itunes_library_parser_unittest.cc',
       'utility/media_galleries/picasa_album_table_reader_unittest.cc',
@@ skipping 632 matching lines @@
           ],
         }],
         ['remoting==1', {
           'dependencies': [
             '../remoting/remoting.gyp:remoting_client_plugin',
           ],
         }],
       ],
     },
     {
+      # GN version: //chrome/test:test_support_unit
       'target_name': 'test_support_unit',
       'type': 'static_library',
       'dependencies': [
         'chrome_resources.gyp:chrome_resources',
         'chrome_resources.gyp:chrome_strings',
         'browser',
         'common',
         'test_support_common',
         '../base/base.gyp:base',
         '../mojo/mojo_base.gyp:mojo_environment_chromium',
         '../skia/skia.gyp:skia',
         '../sync/sync.gyp:sync',
         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
         '../third_party/mojo/mojo_edk.gyp:mojo_system_impl',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'browser/sync/glue/session_sync_test_helper.cc',
         'browser/sync/glue/session_sync_test_helper.h',
         'test/base/run_all_unittests.cc',
       ],
     },
     {
+      # GN version: //chrome/test:unit_tests
       'target_name': 'unit_tests',
       'type': '<(gtest_target_type)',
       'dependencies': [
-        # NOTE: New dependencies should generally be added in the OS!="ios"
+        # NOTE: New depndencies should generally be added in the OS!="ios"

[Dirk Pranke, 2015/01/27 22:37:29]

Nit: typo.

         # dependencies block below, rather than here.
         # Unit tests should only depend on:
         # 1) everything that the chrome binaries depend on:
         '<@(chromium_browser_dependencies)',
         '<@(chromium_child_dependencies)',
         # 2) test-specific support libraries:
         '../base/base.gyp:test_support_base',
         '../components/components_resources.gyp:components_resources',
         '../components/components.gyp:content_settings_core_test_support',
         '../content/content_shell_and_tests.gyp:test_support_content',
@@ skipping 152 matching lines @@
               ],
             }],
           ],
         }],
         ['use_aura==1', {
           'dependencies': [
             '../ui/wm/wm.gyp:wm',
             '../ui/aura/aura.gyp:aura_test_support',
             '../ui/views/views.gyp:views_test_support',
           ],
-          'sources!': [
-            'browser/ui/views/extensions/browser_action_drag_data_unittest.cc',
-          ],
           'sources': [
             '../ui/views/controls/webview/webview_unittest.cc',
           ],
         }],
         ['chromeos==0 and OS=="linux"', {
           'sources': [ '<@(chrome_unit_tests_desktop_linux_sources)' ],
         }],
         ['chromeos==0 and use_ozone==0 and OS=="linux"', {
           'dependencies': [
             'browser/ui/libgtk2ui/libgtk2ui.gyp:gtk2ui',
@@ skipping 32 matching lines @@
             ['chromeos==1', {
               'sources!': [
                 'browser/policy/cloud/user_policy_signin_service_unittest.cc',
               ],
             }],
             ['OS=="android"', {
               'sources!': [
                 'browser/policy/policy_path_parser_unittest.cc',
               ],
             }],
+            ['OS!="android" and OS!="ios" and chromeos==0', {
+              'sources': [
+                'browser/net/disk_cache_dir_policy_handler_unittest.cc',
+              ],
+            }],
+            ['OS!="android" and OS!="ios"', {
+              'sources': [
+                'browser/download/download_dir_policy_handler_unittest.cc'
+              ],
+            }],
           ],
         }],
         ['enable_web_speech==1', {
           'sources': [ '<@(chrome_unit_tests_speech_sources)' ],
         }],
         ['notifications==1', {
           'sources': [ '<@(chrome_unit_tests_notifications_sources)' ],
           'conditions': [
             ['OS == "android"', {
               'sources!': [
@@ skipping 166 matching lines @@
             'Debug': {
               'msvs_settings': {
                 'VCLinkerTool': {
                   'LinkIncremental': '<(msvs_debug_link_nonincremental)',
                 },
               },
             },
           },
         }],
         ['OS=="win"', {
+          'sources': [ '<@(chrome_unit_tests_win_sources)' ],
           'dependencies': [
             'browser/safe_browsing/verifier_test/verifier_unittest.gyp:verifier_test_dll_1',
             'browser/safe_browsing/verifier_test/verifier_unittest.gyp:verifier_test_dll_2',
             'chrome_version_resources',
             'installer_util_strings',
             '../chrome_elf/chrome_elf.gyp:blacklist_test_dll_1',
             '../third_party/iaccessible2/iaccessible2.gyp:iaccessible2',
             '../third_party/isimpledom/isimpledom.gyp:isimpledom',
           ],
           'conditions': [
@@ skipping 18 matching lines @@
           ],
           'link_settings': {
             'libraries': [
               '-lcomsupp.lib',
               '-loleacc.lib',
               '-lrpcrt4.lib',
               '-lurlmon.lib',
               '-lwinmm.lib',
             ],
           },
-        }, { # else: OS != "win"
-          'sources!': [
-            'app/chrome_dll.rc',
-            'browser/search_engines/template_url_scraper_unittest.cc',
-            'browser/ui/views/extensions/browser_action_drag_data_unittest.cc',
-            'test/data/resource.rc',
-          ],
         }],
         ['OS=="android" or OS=="ios"', {
           'sources!': [
             'browser/devtools/device/webrtc/devtools_bridge_instances_request_unittest.cc',
             'browser/ui/sync/sync_promo_ui_unittest.cc',
           ],
         }, { # 'OS!="android" and OS!="ios"'
           'dependencies': [
             'tools/profile_reset/jtl_compiler.gyp:jtl_compiler_lib',
           ],
           'sources!': [
             'browser/metrics/variations/variations_request_scheduler_mobile_unittest.cc',
-            'browser/net/spdyproxy/data_reduction_proxy_settings_unittest.cc',
-            'browser/net/spdyproxy/data_reduction_proxy_settings_unittest.h',
             'browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc',
           ],
         }],
         ['OS != "android" and chromeos == 0', {
           'sources': [ '<@(chrome_unit_tests_non_android_or_chromeos_sources)' ],
         }],
         ['OS=="android"', {
           'dependencies!': [
             '../third_party/libaddressinput/libaddressinput.gyp:libaddressinput',
           ],
           'ldflags': [
             # Some android targets still depend on --gc-sections to link.
             # TODO: remove --gc-sections for Debug builds (crbug.com/159847).
             '-Wl,--gc-sections',
           ],
           'dependencies': [
             '../testing/android/native_test.gyp:native_test_native_code',
           ],
         }, {  # Not Android.
           'sources': [ '<@(chrome_unit_tests_non_android_sources)' ],
         }],
-        ['OS!="android" and OS!="ios" and chromeos==0 and configuration_policy==1', {
-          'sources': [
-            'browser/net/disk_cache_dir_policy_handler_unittest.cc',
-          ],
-        }],
-        ['OS!="android" and OS!="ios" and configuration_policy==1', {
-          'sources': [
-            'browser/download/download_dir_policy_handler_unittest.cc'
-          ],
-        }],
         ['enable_themes == 1', {
           'sources': [ '<@(chrome_unit_tests_themes_sources)' ],
         }],
         ['toolkit_views==1', {
           'dependencies': [
             '../components/components.gyp:web_modal_test_support',
             '../ui/views/views.gyp:views',
             '../ui/views/views.gyp:views_test_support',
           ],
           'conditions': [
@@ skipping 43 matching lines @@
           'sources!': [
             # crbug.com/354036
             'browser/chromeos/events/event_rewriter_unittest.cc',
           ],
         }],
         ['enable_plugin_installation==0', {
           'sources!': [
             'browser/plugins/plugin_installer_unittest.cc',
           ],
         }],
+        # Adding more conditions? Don't forget to update the GN build.
       ],
     },
     {
       'target_name': 'chrome_app_unittests',
       'type': 'executable',
       'dependencies': [
         # unit tests should only depend on
         # 1) everything that the chrome binaries depend on:
         '<@(chromium_browser_dependencies)',
         '<@(chromium_child_dependencies)',
@@ skipping 132 matching lines @@
               'dependencies': [
                 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
               ],
             }],
           ],
         },
       ],
     }],
   ],  # 'conditions'
 }