Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 880813004: Make msvs-ninja work for target_arch=x64 (Closed)

Created:
5 years, 10 months ago by danduong
Modified:
5 years, 10 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make msvs-ninja work for target-arch=x64 This adds _x64 to the OutDir for msvs project files when ninja builds are enabled for x64. Patch from danduong@chromium.org. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=2033

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M pylib/gyp/__init__.py View 1 chunk +2 lines, -1 line 0 comments Download
M pylib/gyp/generator/msvs.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
danduong
Scott, PTAL.
5 years, 10 months ago (2015-02-10 23:09:00 UTC) #2
scottmg
I don't use this generator, but wouldn't Configuration have _x64 in it already? https://codereview.chromium.org/880813004/diff/1/pylib/gyp/generator/msvs.py File ...
5 years, 10 months ago (2015-02-11 00:08:24 UTC) #3
danduong
$(Configuration) doesn't have _x64 in it. That information is available in $(Platform) though. https://codereview.chromium.org/880813004/diff/1/pylib/gyp/generator/msvs.py File ...
5 years, 10 months ago (2015-02-11 22:46:44 UTC) #4
scottmg
LGTM. I can land it for you. https://codereview.chromium.org/880813004/diff/20001/pylib/gyp/generator/msvs.py File pylib/gyp/generator/msvs.py (right): https://codereview.chromium.org/880813004/diff/20001/pylib/gyp/generator/msvs.py#newcode1868 pylib/gyp/generator/msvs.py:1868: if target_arch ...
5 years, 10 months ago (2015-02-11 22:58:14 UTC) #5
danduong
https://codereview.chromium.org/880813004/diff/20001/pylib/gyp/generator/msvs.py File pylib/gyp/generator/msvs.py (right): https://codereview.chromium.org/880813004/diff/20001/pylib/gyp/generator/msvs.py#newcode1868 pylib/gyp/generator/msvs.py:1868: if target_arch == 'x64': On 2015/02/11 22:58:14, scottmg wrote: ...
5 years, 10 months ago (2015-02-11 23:26:08 UTC) #7
scottmg
5 years, 10 months ago (2015-02-11 23:31:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 2033 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698