pylib/gyp/__init__.py - Issue 880813004: Make msvs-ninja work for target_arch=x64 - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(743)

My Issues | Starred Open | Closed | All

Unified Diff: pylib/gyp/init.py

Issue 880813004: Make msvs-ninja work for target_arch=x64 (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | pylib/gyp/generator/msvs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pylib/gyp/__init__.py

diff --git a/pylib/gyp/__init__.py b/pylib/gyp/__init__.py

index e43a72418be9124c28255f43114fea04ddd648d1..b10d97a93bd0d57c847b4b52d6857dc3ed0a1243 100755

--- a/pylib/gyp/__init__.py

+++ b/pylib/gyp/__init__.py

@@ -493,7 +493,8 @@ def gyp_main(args):

'gyp_binary': sys.argv[0],

'home_dot_gyp': home_dot_gyp,

'parallel': options.parallel,

- 'root_targets': options.root_targets}

+ 'root_targets': options.root_targets,

+ 'target_arch': cmdline_default_variables.get('target_arch', '')}

# Start with the default variables from the command line.

[generator, flat_list, targets, data] = Load(

« no previous file with comments | « no previous file | pylib/gyp/generator/msvs.py » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698