Issue 880713003: Rename scheduleAnimation() to scheduleVisualUpdate().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 880713003: Rename scheduleAnimation() to scheduleVisualUpdate(). (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Rename scheduleAnimation() to scheduleVisualUpdate(). It causes a full screen raster right now, lets name it for what it does. This also matches the name used in PageAnimator. Merge WebWidgetClient into WebViewClient. They're always the same thing in sky. I also removed all the methods that don't do anything in sky. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a4f2011d661d9a9e32d353d9c41916a30dbdbbe1

Patch Set 1 #

Patch Set 2 : rebase. #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -33 lines)			Patch
M	sky/engine/core/loader/EmptyClients.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/page/Chrome.h	View		3 chunks	+3 lines, -4 lines	0 comments	Download
M	sky/engine/core/page/Chrome.cpp	View		4 chunks	+6 lines, -10 lines	0 comments	Download
M	sky/engine/core/page/ChromeClient.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/page/Page.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/page/PageAnimator.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/page/PageAnimator.cpp	View		3 chunks	+1 line, -4 lines	0 comments	Download
M	sky/engine/platform/HostWindow.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/public/web/WebViewClient.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/web/ChromeClientImpl.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/web/ChromeClientImpl.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/viewer/document_view.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/viewer/document_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

esprehn

5 years, 11 months ago (2015-01-27 00:09:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a4f2011d661d9a9e32d353d9c41916a30dbdbbe1 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages